ref: Make react_config available in context #81654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch refactors a 10-year-old hack where we used a template tag to produce the initial data JSON, making the contents of that blob unavailable to any Django template. With this, all views extending from base gets a `react_config` context object so we can do things like sniffing user's language or theme preferences if available and modify the HTML output based on that. Related #81611
github-actions
bot
added
the
Scope: Backend
|
@scttcper - if this works, we should be able to do something like |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81654 +/- ##
==========================================
+ Coverage 80.35% 80.46% +0.10%
==========================================
Files 7253 7252 -1
Lines 320569 321989 +1420
Branches 20859 20811 -48
==========================================
+ Hits 257600 259082 +1482
+ Misses 62574 62507 -67
- Partials 395 400 +5 |
markstory
reviewed
Dec 4, 2024
markstory
approved these changes
Dec 6, 2024
mifu67
pushed a commit
that referenced
this pull request
Dec 10, 2024
This patch refactors a 10-year-old hack where we used a template tag to produce the initial data JSON, making the contents of that blob unavailable to any Django template. With this, all views extending from base gets a `react_config` context object so we can do things like sniffing user's language or theme preferences if available and modify the HTML output based on that. Related #81611
BYK
added a commit
that referenced
this pull request
Dec 19, 2024
Follow up to #81654 and should fix getsentry/self-hosted#3473
BYK
added a commit
that referenced
this pull request
Dec 19, 2024
Follow up to #81654 and should fix getsentry/self-hosted#3473
BYK
added a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors a 10-year-old hack where we used a template tag to produce the initial data JSON, making the contents of that blob unavailable to any Django template. With this, all views extending from base gets a
react_configcontext object so we can do things like sniffing user's language or theme preferences if available and modify the HTML output based on that.Related #81611