feat(ui): Add dark app loading theme #81611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gets the user's config from `window.__initialData` and attempts to style the initial ui by adding a class to the body
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Bundle ReportChanges will increase total bundle size by 1.09kB (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
JonasBa
reviewed
Dec 3, 2024
JonasBa
approved these changes
Dec 4, 2024
static/less/shared-components.less
Outdated
| .theme-dark { | ||
| .loading { | ||
| .loading-indicator { | ||
| // surface200 |
There was a problem hiding this comment.
thank you for leaving the comments, makes finding future references much easier!
BYK
added a commit
that referenced
this pull request
Dec 4, 2024
This patch refactors a 10-year-old hack where we used a template tag to produce the initial data JSON, making the contents of that blob unavailable to any Django template. With this, all views extending from base gets a `react_config` context object so we can do things like sniffing user's language or theme preferences if available and modify the HTML output based on that. Related #81611
BYK
added a commit
that referenced
this pull request
Dec 6, 2024
This patch refactors a 10-year-old hack where we used a template tag to produce the initial data JSON, making the contents of that blob unavailable to any Django template. With this, all views extending from base gets a `react_config` context object so we can do things like sniffing user's language or theme preferences if available and modify the HTML output based on that. Related #81611
# Conflicts: # static/app/components/loadingTriangle.tsx
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81611 +/- ##
=======================================
Coverage 80.34% 80.34%
=======================================
Files 7272 7272
Lines 321262 321266 +4
Branches 20947 20947
=======================================
+ Hits 258123 258127 +4
Misses 62736 62736
Partials 403 403 |
BYK
reviewed
Dec 9, 2024
| @@ -18,3 +18,5 @@ | |||
| </div> | |||
| </div> | |||
| {% endblock %} | |||
|
|
|||
| {% block wrapperclass %}{{ user_theme }}{% endblock %} | |||
mifu67
pushed a commit
that referenced
this pull request
Dec 10, 2024
This patch refactors a 10-year-old hack where we used a template tag to produce the initial data JSON, making the contents of that blob unavailable to any Django template. With this, all views extending from base gets a `react_config` context object so we can do things like sniffing user's language or theme preferences if available and modify the HTML output based on that. Related #81611
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses react_context to add
theme-user_option_themeto the body's class to avoid screen flashing before the app loadsinverted the svg which is inside the img tag which makes it harder to style. made it slightly opaque since the black/white was a bit loud.
fixes #81555
related #81654