fix(ui): Remove theme classname on switch #81973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
BYK
approved these changes
Dec 11, 2024
| @@ -28,6 +28,10 @@ const formGroups: JsonFormObject[] = [ | |||
| {value: 'system', label: t('Default to system')}, | |||
| ], | |||
| getData: transformOptions, | |||
| onChange: () => { | |||
| // Remove any existing theme class from when the page was loaded | |||
| document.body.classList.remove('theme-light', 'theme-dark', 'theme-system'); | |||
There was a problem hiding this comment.
I'd make this a helper function so we don't repeat the theme class names in more than 1 place. That said, for the current state of things I'm fine with only 2 places and 3 names especially if it is unlikely that we'd need this anywhere else. Maybe add a TODO: note for this kind of future work?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the classname when toggling between themes
related #81611