ref: switch from mywsgi/uwsgi to pyuwsgi #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile-sentry
force-pushed
the
asottile-pyuwsgi
branch
from
056a5ed to
365f19c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3076 +/- ##
==========================================
+ Coverage 92.53% 92.72% +0.19%
==========================================
Files 655 656 +1
Lines 30353 30379 +26
==========================================
+ Hits 28087 28170 +83
+ Misses 2266 2209 -57
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
asottile-sentry
commented
Aug 19, 2022
Comment on lines
+45
to
+69
| options: dict[str, bool | int | str | None] = { | ||
| "auto_procname": True, | ||
| "chmod_socket": 777, | ||
| "die_on_term": True, | ||
| "disable_write_exception": True, | ||
| "enable_threads": True, | ||
| "ignore_sigpipe": True, | ||
| "ignore_write_errors": True, | ||
| "lazy_apps": True, | ||
| "log_format": '%(addr) - %(user) [%(ltime)] "%(method) %(uri) %(proto)" %(status) %(size) "%(referer)" "%(uagent)"', | ||
| "log_x_forwarded_for": True, | ||
| "master": True, | ||
| "module": module, | ||
| "need_app": True, | ||
| "processes": 1, | ||
| "protocol": protocol, | ||
| "single_interpreter": True, | ||
| "threads": 1, | ||
| "thunder_lock": True, | ||
| "vacuum": True, | ||
| "virtualenv": sys.prefix, | ||
| "wsgi_env_behavior": "holy", | ||
| f"{protocol}_socket": bind, | ||
| **kwargs, | ||
| } |
There was a problem hiding this comment.
these are copied from mywsgi which appear to be copied from sentry
|
not planning to merge or roll this out until after |
asottile-sentry
commented
Aug 19, 2022
| @@ -46,13 +47,11 @@ def api( | |||
| WSGIRequestHandler.protocol_version = "HTTP/1.1" | |||
| application.run(host=host, port=port, threaded=True, debug=debug) | |||
| else: | |||
| import mywsgi | |||
|
|
|||
| if log_level: | |||
| os.environ["LOG_LEVEL"] = log_level | |||
|
|
|||
| with flush_attribution_producer(): | |||
There was a problem hiding this comment.
unrelated to this patch but this call does nothing! both myuwsgi.run and snuba.utils.uwsgi.run end with os.execvp which replaces the current process
evanh
approved these changes
Aug 29, 2022
pyuwsgi provides wheels making it much faster to install whereas uwsgi isn't wheelable
asottile-sentry
force-pushed
the
asottile-pyuwsgi
branch
from
365f19c to
4c860c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyuwsgi provides wheels making it much faster to install whereas uwsgi isn't wheelable
this also cuts about 10 minutes from the uncached arm64 image build (17 minutes -> 7 minutes)