Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: set binary-path for pyuwsgi to be reloadable #3101

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Aug 31, 2022

I regressed reloadability in #3076 (a reload would cause uwsgi to lose the virtualenv)

see also unbit/uwsgi#2478

@codecov-commenter
Copy link

Codecov Report

Base: 93.08% // Head: 93.02% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (7ed0ad8) compared to base (f28d52f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3101      +/-   ##
==========================================
- Coverage   93.08%   93.02%   -0.06%     
==========================================
  Files         662      662              
  Lines       30483    30483              
==========================================
- Hits        28374    28356      -18     
- Misses       2109     2127      +18     
Impacted Files Coverage Δ
snuba/utils/uwsgi.py 26.92% <ø> (ø)
snuba/settings/settings_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
snuba/settings/settings_test_distributed.py 0.00% <0.00%> (-100.00%) ⬇️
...ts/0010_groupedmessages_onpremise_compatibility.py 95.55% <0.00%> (-4.45%) ⬇️
snuba/migrations/table_engines.py 95.50% <0.00%> (-3.38%) ⬇️
snuba/optimize.py 89.10% <0.00%> (-2.98%) ⬇️
...nsactions_onpremise_fix_orderby_and_partitionby.py 81.33% <0.00%> (-2.67%) ⬇️
tests/migrations/test_runner_individual.py 91.20% <0.00%> (-2.20%) ⬇️
snuba/clusters/cluster.py 95.17% <0.00%> (-1.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@asottile-sentry asottile-sentry marked this pull request as ready for review August 31, 2022 13:52
@asottile-sentry asottile-sentry requested a review from a team as a code owner August 31, 2022 13:52
@asottile-sentry asottile-sentry merged commit 5702de2 into master Aug 31, 2022
@asottile-sentry asottile-sentry deleted the asottile-binary-path branch August 31, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants