feat(sdk): Assign nanoid to findings for cross-referencing in reports#110
Merged
feat(sdk): Assign nanoid to findings for cross-referencing in reports#110
Conversation
Replace LLM-provided finding IDs with short, stable nanoids generated by Warden. These IDs appear in PR review comments, summary comments, issue bodies, and CLI output for cross-referencing across reports. Closes #107 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Use uppercase alphanumeric alphabet without ambiguous characters (O/0, I/1) and format as XXX-XXX (e.g., K7M-X9P) for readability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
The dedup key used f.id, but since IDs are now unique nanoids, two identical findings would never match. Use f.title instead since title + location is what identifies a duplicate finding. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace LLM-provided finding IDs with short, stable 8-char nanoids
generated by Warden during validation. The LLM-provided IDs were
arbitrary strings ("example-1", "sql-injection") that couldn't be
relied on for cross-referencing across reports, cost summaries, or
judge reporting.
Now each finding gets a unique nanoid assigned in
validateFindings(),and the ID is displayed in all output surfaces: PR review comments,
summary comments, GitHub issue bodies, and CLI terminal output.
Fixes #107