feat(config): Add configurable maxTurns with default of 50#47
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| options: SkillRunnerOptions | ||
| ): Promise<HunkAnalysisResult> { | ||
| const { maxTurns = 5, model, abortController, pathToClaudeCodeExecutable } = options; | ||
| const { maxTurns = 50, model, abortController, pathToClaudeCodeExecutable } = options; |
Contributor
There was a problem hiding this comment.
🟠 10x increase in maxTurns default may cause resource exhaustion
The default maxTurns value was increased from 5 to 50. This 10x increase could lead to significantly longer execution times and higher API costs if the analysis gets stuck in a loop or takes many iterations. While 5 turns may have been too restrictive for complex analysis, 50 turns without any timeout or cost guard could be excessive.
Suggested fix: Consider a more moderate increase (e.g., 15-20) or add a cost/time guard to prevent runaway analysis. Also consider making this configurable per-skill if different skills have different complexity needs.
Suggested change
| const { maxTurns = 50, model, abortController, pathToClaudeCodeExecutable } = options; | |
| const { maxTurns = 15, model, abortController, pathToClaudeCodeExecutable } = options; |
warden: find-bugs
Allow maxTurns to be configured in warden.toml at both the defaults level and per-trigger. This prevents error_max_turns when skills need more agentic turns for thorough analysis. Precedence: trigger.maxTurns > defaults.maxTurns > hardcoded default (50) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
731788c to
1cc166b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxTurnsconfig option towarden.tomlat both defaults and per-trigger levelserror_max_turnsduring thorough analysistrigger.maxTurns>defaults.maxTurns> hardcoded default (50)Example
Test plan