-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat(config): Add configurable maxTurns with default of 50 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -236,7 +236,7 @@ | |||||
| repoPath: string, | ||||||
| options: SkillRunnerOptions | ||||||
| ): Promise<HunkAnalysisResult> { | ||||||
| const { maxTurns = 5, model, abortController, pathToClaudeCodeExecutable } = options; | ||||||
| const { maxTurns = 50, model, abortController, pathToClaudeCodeExecutable } = options; | ||||||
|
Check warning on line 239 in src/sdk/runner.ts
|
||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 10x increase in maxTurns default may cause resource exhaustion The default maxTurns value was increased from 5 to 50. This 10x increase could lead to significantly longer execution times and higher API costs if the analysis gets stuck in a loop or takes many iterations. While 5 turns may have been too restrictive for complex analysis, 50 turns without any timeout or cost guard could be excessive. Suggested fix: Consider a more moderate increase (e.g., 15-20) or add a cost/time guard to prevent runaway analysis. Also consider making this configurable per-skill if different skills have different complexity needs.
Suggested change
warden: find-bugs |
||||||
|
|
||||||
| const systemPrompt = buildHunkSystemPrompt(skill); | ||||||
| const userPrompt = buildHunkUserPrompt(hunkCtx); | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.