feat(action): Improve duplicate comment UX by dcramer · Pull Request #60 · getsentry/warden

dcramer · 2026-01-31T04:59:50Z

Improve the user experience when Warden detects duplicate findings.

Previously, when a finding duplicated an existing comment, Warden silently
skipped it. This left users wondering whether the skill ran at all, and
provided no visibility into cross-skill detection.

Now Warden takes action on duplicates:

Warden's own comments: Updates the existing comment to add the new skill
to the attribution line (e.g., warden: security-review, code-quality)
External comments: Adds an 👀 reaction to acknowledge that Warden also
detected the issue

This provides better visibility into which skills detected each issue and
acknowledges when humans have already identified problems that Warden would
have flagged.

Fixes #45

When Warden detects a duplicate finding, instead of silently skipping: - For Warden's own comments: update the existing comment to add the new skill to the attribution (e.g., "warden: skill1, skill2") - For external comments: add an 👀 reaction to acknowledge This provides better visibility into which skills detected each issue and acknowledges when humans have already identified problems. Fixes #45 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

vercel · 2026-01-31T04:59:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
warden	Ready	Preview, Comment	Jan 31, 2026 4:39pm

sentry-warden

notseer

notseer: Found 1 issue (1 medium)

_{⏱ 203.8s · 544.3k in / 9.6k out · $1.32}

sentry-warden · 2026-01-31T05:03:54Z

src/output/dedup.ts

+  const allSkills = [...existingSkills, newSkill].join(', ');
+  return body.replace(/<sub>warden:\s*[^<]+<\/sub>/, `<sub>warden: ${allSkills}</sub>`);


🟠 updateWardenCommentBody returns unchanged body when _{tag is missing} (high confidence)

When a Warden comment is identified via marker only (no warden: tag), parseWardenSkills returns empty array, existingSkills.includes(newSkill) is false, and the replace at line 164 matches nothing, returning the original body unchanged. The caller at line 472 checks if (newBody) which is truthy, triggering an unnecessary API update with unchanged content.

Suggested fix: Check if the replacement actually occurred before returning

Suggested change

const allSkills = [...existingSkills, newSkill].join(', ');

return body.replace(/warden:\s*[^<]+<\/sub>/, `warden: ${allSkills}`);

// If no existing warden:... tag exists, we can't update it

if (existingSkills.length === 0) {

return null;

}

_{warden: notseer}

src/output/dedup.ts

- Return null from updateWardenCommentBody when no warden:... tag exists, preventing unnecessary API calls with unchanged content - Use replacer function in String.replace() to avoid special $ character interpretation in skill names - Update in-memory body after successful API update so subsequent triggers see the updated content instead of stale data Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

sentry · 2026-01-31T16:42:56Z

src/output/dedup.ts

-    const duplicateIndices = DuplicateIndicesSchema.parse(JSON.parse(content.text));
-    const duplicateIds = new Set<string>();
+    const parsed = DuplicateMatchesSchema.parse(JSON.parse(content.text));
+    const matches = new Map<string, ExistingComment>();

-    for (const num of duplicateIndices) {
-      // Convert 1-based index to 0-based
-      const finding = findings[num - 1];
-      if (finding) {
-        duplicateIds.add(finding.id);
+    for (const match of parsed) {
+      const finding = findings[match.findingIndex - 1];
+      const existing = existingComments[match.existingIndex - 1];
+      if (finding && existing) {
+        matches.set(finding.id, existing);
      }


Bug: External (non-Warden) comments are assigned an empty title in fetchExistingComments, causing generateContentHash to produce a mismatched hash and breaking hash-based deduplication against new findings.
_{Severity: MEDIUM}

Suggested Fix

Modify fetchExistingComments to attempt to parse a title from the body of external comments instead of defaulting to an empty string. For example, the first line of the comment body could be treated as the title. This would allow generateContentHash to create matching hashes for identical findings and external comments, enabling hash-based deduplication to work as intended.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: src/output/dedup.ts#L278-L286 Potential issue: In the `fetchExistingComments` function, when processing existing GitHub comments that are not in the Warden format (external comments), the code fails to extract a title. The `parseWardenComment` function returns `null` for these comments, causing the `title` variable to be assigned an empty string. Consequently, the `generateContentHash(title, description)` function creates a hash based on an empty title for the external comment. This hash will not match the hash of a new finding that has a non-empty title, even if the content is otherwise identical. This failure prevents hash-based deduplication from working for external comments, meaning duplicates will only be caught if LLM-based semantic deduplication is available and successful.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-01-31T16:51:13Z

src/action/main.ts

+              console.log(`Added reactions to ${actionCounts.reacted} existing external comments`);
+            }
+            if (actionCounts.failed > 0) {
+              console.warn(`::warning::Failed to process ${actionCounts.failed} duplicate actions`);


Skipped duplicate actions not logged, reducing user visibility

Medium Severity

The processDuplicateActions function returns a skipped count, but this value is never logged in main.ts. When multiple triggers in the same run detect the same issue, duplicate actions are created but always skipped because findingToExistingComment creates in-memory comments without the body property needed for updates. Users see "Found N duplicate findings" in logs but get no indication that skill attribution updates were skipped. This contradicts the PR's goal of "providing better visibility into which skills detected each issue."

Additional Locations (1)

src/output/dedup.ts#L511-L521

sentry-warden bot reviewed Jan 31, 2026

View reviewed changes

cursor bot reviewed Jan 31, 2026

View reviewed changes

src/output/dedup.ts Show resolved Hide resolved

src/output/dedup.ts Show resolved Hide resolved

src/output/dedup.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview January 31, 2026 16:39 View deployment

sentry bot reviewed Jan 31, 2026

View reviewed changes

dcramer merged commit e32472f into main Jan 31, 2026
14 checks passed

dcramer deleted the feat/duplicate-comment-ux branch January 31, 2026 16:45

cursor bot reviewed Jan 31, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(action): Improve duplicate comment UX#60

feat(action): Improve duplicate comment UX#60
dcramer merged 2 commits intomainfrom
feat/duplicate-comment-ux

dcramer commented Jan 31, 2026

Uh oh!

vercel bot commented Jan 31, 2026 •

edited

Loading

Uh oh!

sentry-warden bot left a comment

Uh oh!

sentry-warden bot Jan 31, 2026 •

edited by dcramer

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentry bot Jan 31, 2026

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		const allSkills = [...existingSkills, newSkill].join(', ');
		return body.replace(/<sub>warden:\s*[^<]+<\/sub>/, `<sub>warden: ${allSkills}</sub>`);

-  const allSkills = [...existingSkills, newSkill].join(', ');
-  return body.replace(/<sub>warden:\s*[^<]+<\/sub>/, `<sub>warden: ${allSkills}</sub>`);
+  // If no existing <sub>warden:...</sub> tag exists, we can't update it
+  if (existingSkills.length === 0) {
+    return null;
+  }

Uh oh!

Conversation

dcramer commented Jan 31, 2026

Uh oh!

vercel bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sentry-warden bot left a comment

Choose a reason for hiding this comment

notseer

Uh oh!

sentry-warden bot Jan 31, 2026 • edited by dcramer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentry bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 31, 2026

Choose a reason for hiding this comment

Skipped duplicate actions not logged, reducing user visibility

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel bot commented Jan 31, 2026 •

edited

Loading

sentry-warden bot Jan 31, 2026 •

edited by dcramer

Loading