-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minify support #1146
Add minify support #1146
Conversation
This feature is already exist, but not in the doc yet Related getzola#766
9a5aee3
to
0a8d4f3
Compare
Gone to WIP status because of a problem found with It appears to turn : |
@Keats this is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move the minification to write_content
so we can't forget it and no need to repeat ourselves everywhere
I moved the |
Seems good, can you add a couple of tests for the minified output? |
I added a test for EDIT : it appears to break other tests, will correct that |
Thanks! I'll bump the pinned version myself for the build to pass |
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
next
branch?If the change is a new feature or adding to/changing an existing one:
Closes #542