Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better minify errors #1154

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Better minify errors #1154

merged 2 commits into from
Sep 8, 2020

Conversation

areille
Copy link
Contributor

@areille areille commented Sep 2, 2020

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

Description

Closes #1152.

@areille areille changed the base branch from master to next September 2, 2020 07:44
@areille areille changed the title Fix minify error Betterminify errors Sep 2, 2020
@areille areille changed the title Betterminify errors Better minify errors Sep 2, 2020
@Keats Keats closed this Sep 4, 2020
@Keats Keats reopened this Sep 4, 2020
@areille
Copy link
Contributor Author

areille commented Sep 6, 2020

@Keats do you want me to revert back the previous pr (#1146) in this one ?

@Keats
Copy link
Collaborator

Keats commented Sep 7, 2020

It's already merged in released in 0.12, it just needs to be enabled + add back the docs

@Keats Keats merged commit d26960d into getzola:next Sep 8, 2020
@Keats
Copy link
Collaborator

Keats commented Sep 8, 2020

Thanks!

@areille
Copy link
Contributor Author

areille commented Oct 10, 2020

@Keats should I open a new PR to re-enable minify-html ? I saw that it is forced set to false in config's mod.rs

@Keats
Copy link
Collaborator

Keats commented Oct 11, 2020

Yes please! Hopefully the big issues are fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minfying has unhelpful error messaging and breaks on html chars in inner text
3 participants