Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid building shaders in build.rs scripts #3046

Closed
kvark opened this issue Oct 16, 2019 · 0 comments · Fixed by #3047
Closed

Avoid building shaders in build.rs scripts #3046

kvark opened this issue Oct 16, 2019 · 0 comments · Fixed by #3047
Labels
backend: DirectX-12 backend: Metal difficulty: easy module: infrastructure platform: OSX platform: Windows status: ready for work type: feature value: medium

Comments

@kvark
Copy link
Member

kvark commented Oct 16, 2019 •
edited
Loading

Doing so is not compatible with cross-compilation, which for example is what Gecko try bots do for testing macOS.
Instead, we should have a make command to update shader binaries based on the source, and both the source with the binaries are going to be versioned.
@kvark kvark pinned this issue Oct 16, 2019
@grovesNL grovesNL mentioned this issue Oct 17, 2019
Merged
4 tasks
bors bot added a commit that referenced this issue Oct 18, 2019
@bors @grovesNL
Merge #3047
48cbada 
3047: Build Metal shaders in Makefile instead of build.rs r=kvark a=grovesNL

Fixes #3046
PR checklist:
- [X] `make` succeeds (on *nix)
- [ ] `make reftests` succeeds
- [X] tested examples with the following backends: metal
- [ ] `rustfmt` run on changed code


Co-authored-by: Joshua Groves <josh@joshgroves.com>
@bors bors bot closed this as completed in 149c10b Oct 18, 2019
@kvark kvark unpinned this issue Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend: DirectX-12 backend: Metal difficulty: easy module: infrastructure platform: OSX platform: Windows status: ready for work type: feature value: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build Metal shaders in Makefile instead of build.rs grovesNL/gfx
1 participant
@kvark