Build Metal shaders in Makefile instead of build.rs #3047

grovesNL · 2019-10-17T02:02:51Z

Fixes #3046
PR checklist:

make succeeds (on *nix)
make reftests succeeds
tested examples with the following backends: metal
rustfmt run on changed code

Makefile

kvark

Wonderful, thank you!
bors r+

3047: Build Metal shaders in Makefile instead of build.rs r=kvark a=grovesNL Fixes #3046 PR checklist: - [X] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [X] tested examples with the following backends: metal - [ ] `rustfmt` run on changed code Co-authored-by: Joshua Groves <josh@joshgroves.com>

bors · 2019-10-18T02:31:04Z

Build failed

continuous-integration/travis-ci/push

grovesNL · 2019-10-18T02:44:18Z

bors r=kvark

3047: Build Metal shaders in Makefile instead of build.rs r=kvark a=grovesNL Fixes #3046 PR checklist: - [X] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [X] tested examples with the following backends: metal - [ ] `rustfmt` run on changed code Co-authored-by: Joshua Groves <josh@joshgroves.com>

bors · 2019-10-18T03:03:42Z

Build succeeded

continuous-integration/travis-ci/push

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://bugzilla.mozilla.org/show_bug.cgi?id=1592398 - [x] undefined Metal symbols - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458 --HG-- rename : dom/webgpu/Adapter.cpp => dom/webgpu/ipc/WebGPUTypes.h rename : third_party/rust/arrayvec/.cargo-checksum.json => third_party/rust/arrayvec-0.4.11/.cargo-checksum.json rename : third_party/rust/arrayvec/Cargo.toml => third_party/rust/arrayvec-0.4.11/Cargo.toml rename : third_party/rust/arrayvec/README.rst => third_party/rust/arrayvec-0.4.11/README.rst rename : third_party/rust/arrayvec/benches/extend.rs => third_party/rust/arrayvec-0.4.11/benches/extend.rs rename : third_party/rust/arrayvec/build.rs => third_party/rust/arrayvec-0.4.11/build.rs rename : third_party/rust/arrayvec/src/array.rs => third_party/rust/arrayvec-0.4.11/src/array.rs rename : third_party/rust/arrayvec/src/array_string.rs => third_party/rust/arrayvec-0.4.11/src/array_string.rs rename : third_party/rust/arrayvec/src/char.rs => third_party/rust/arrayvec-0.4.11/src/char.rs rename : third_party/rust/arrayvec/src/lib.rs => third_party/rust/arrayvec-0.4.11/src/lib.rs rename : third_party/rust/arrayvec/src/maybe_uninit.rs => third_party/rust/arrayvec-0.4.11/src/maybe_uninit.rs rename : third_party/rust/arrayvec/src/maybe_uninit_nodrop.rs => third_party/rust/arrayvec-0.4.11/src/maybe_uninit_nodrop.rs rename : third_party/rust/arrayvec/src/maybe_uninit_stable.rs => third_party/rust/arrayvec-0.4.11/src/maybe_uninit_stable.rs rename : third_party/rust/arrayvec/src/range.rs => third_party/rust/arrayvec-0.4.11/src/range.rs rename : third_party/rust/arrayvec/tests/serde.rs => third_party/rust/arrayvec-0.4.11/tests/serde.rs rename : third_party/rust/arrayvec/tests/tests.rs => third_party/rust/arrayvec-0.4.11/tests/tests.rs rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/atom/Cargo.toml rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/cocoa/Cargo.toml rename : third_party/rust/core-graphics/src/lib.rs => third_party/rust/cocoa/src/lib.rs rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/colorful/Cargo.toml rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/range-alloc/Cargo.toml rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/shared_library/Cargo.toml rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/x11/Cargo.toml extra : moz-landing-system : lando

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://bugzilla.mozilla.org/show_bug.cgi?id=1592398 - [x] undefined Metal symbols - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://bugzilla.mozilla.org/show_bug.cgi?id=1592398 - [x] undefined Metal symbols - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458 UltraBlame original commit: 9c05fa3c0fcceb4f557d81e7a740bf81992aecb8

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://bugzilla.mozilla.org/show_bug.cgi?id=1592398 - [x] undefined Metal symbols - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458 UltraBlame original commit: ef59d327a1a45ec7ccc9a6965e08c2325e64e336

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://bugzilla.mozilla.org/show_bug.cgi?id=1592398 - [x] undefined Metal symbols - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458 UltraBlame original commit: 9c05fa3c0fcceb4f557d81e7a740bf81992aecb8

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://bugzilla.mozilla.org/show_bug.cgi?id=1592398 - [x] undefined Metal symbols - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458 UltraBlame original commit: ef59d327a1a45ec7ccc9a6965e08c2325e64e336

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://bugzilla.mozilla.org/show_bug.cgi?id=1592398 - [x] undefined Metal symbols - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458 UltraBlame original commit: 9c05fa3c0fcceb4f557d81e7a740bf81992aecb8

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://bugzilla.mozilla.org/show_bug.cgi?id=1592398 - [x] undefined Metal symbols - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458 UltraBlame original commit: ef59d327a1a45ec7ccc9a6965e08c2325e64e336

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://phabricator.services.mozilla.com/D51148 - [x] undefined Metal symbols - [x] missing webrtc headers for IPDL magic - https://phabricator.services.mozilla.com/D51558 - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] cc mislinking C++ standard library - rust-lang/cc-rs#455 - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458 --HG-- rename : dom/webgpu/Adapter.cpp => dom/webgpu/ipc/WebGPUTypes.h rename : third_party/rust/arrayvec/.cargo-checksum.json => third_party/rust/arrayvec-0.4.11/.cargo-checksum.json rename : third_party/rust/arrayvec/Cargo.toml => third_party/rust/arrayvec-0.4.11/Cargo.toml rename : third_party/rust/arrayvec/README.rst => third_party/rust/arrayvec-0.4.11/README.rst rename : third_party/rust/arrayvec/benches/extend.rs => third_party/rust/arrayvec-0.4.11/benches/extend.rs rename : third_party/rust/arrayvec/build.rs => third_party/rust/arrayvec-0.4.11/build.rs rename : third_party/rust/arrayvec/src/array.rs => third_party/rust/arrayvec-0.4.11/src/array.rs rename : third_party/rust/arrayvec/src/array_string.rs => third_party/rust/arrayvec-0.4.11/src/array_string.rs rename : third_party/rust/arrayvec/src/char.rs => third_party/rust/arrayvec-0.4.11/src/char.rs rename : third_party/rust/arrayvec/src/lib.rs => third_party/rust/arrayvec-0.4.11/src/lib.rs rename : third_party/rust/arrayvec/src/maybe_uninit.rs => third_party/rust/arrayvec-0.4.11/src/maybe_uninit.rs rename : third_party/rust/arrayvec/src/maybe_uninit_nodrop.rs => third_party/rust/arrayvec-0.4.11/src/maybe_uninit_nodrop.rs rename : third_party/rust/arrayvec/src/maybe_uninit_stable.rs => third_party/rust/arrayvec-0.4.11/src/maybe_uninit_stable.rs rename : third_party/rust/arrayvec/src/range.rs => third_party/rust/arrayvec-0.4.11/src/range.rs rename : third_party/rust/arrayvec/tests/serde.rs => third_party/rust/arrayvec-0.4.11/tests/serde.rs rename : third_party/rust/arrayvec/tests/tests.rs => third_party/rust/arrayvec-0.4.11/tests/tests.rs rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/atom/Cargo.toml rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/cocoa/Cargo.toml rename : third_party/rust/core-graphics/src/lib.rs => third_party/rust/cocoa/src/lib.rs rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/colorful/Cargo.toml rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/range-alloc/Cargo.toml rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/shared_library/Cargo.toml rename : third_party/rust/core-graphics/Cargo.toml => third_party/rust/x11/Cargo.toml extra : moz-landing-system : lando

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://phabricator.services.mozilla.com/D51148 - [x] undefined Metal symbols - [x] missing webrtc headers for IPDL magic - https://phabricator.services.mozilla.com/D51558 - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] cc mislinking C++ standard library - rust-lang/cc-rs#455 - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458

This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Current status: - [x] Architecture - [x] figure out the IPC story - [ ] move wgpu crates into a dedicated folder (let's follow up with this) - [x] Review - [x] WebIDL changes by DOM peers - [x] Linux - [x] avoid depending on spirv_cross - gfx-rs/wgpu#371 - [x] macOS - [x] due to cross-compiling shaders - gfx-rs/gfx#3047 - [x] need the dependency update - [x] stop using gcc - SSheldon/rust-objc-exception#5 - [x] unexpected SSL header collision - https://phabricator.services.mozilla.com/D51148 - [x] undefined Metal symbols - [x] missing webrtc headers for IPDL magic - https://phabricator.services.mozilla.com/D51558 - [x] Windows - [x] due to "ipc-channel" not supporting Windows yet - servo/ipc-channel#233 - [x] due to some exceptional stuff - grovesNL/spirv_cross#121 - [x] undefined symbol: `D3D12CreateDevice` - [x] d3d12.dll is not found, dxgi1_4 doesn't present - [x] d3d11.dll and dxgi.dll need to be explicitly loaded on win32 mingw - gfx-rs/gfx#3076 - [x] libbacktrace fails to link on win32 mingw - [x] cc mislinking C++ standard library - rust-lang/cc-rs#455 - [x] Android - [x] spirv-cross fails to build - KhronosGroup/SPIRV-Cross#1193 Update-1: We decided to go with IPDL mechanism instead of Rust based ipc-channel (or any alternatives), which unblocks Windows build. Update-2: It appears that WebGPUThreading isn't needed any more as the child thread (and its event loop) is now managed by IPDL infrastructure. This PR removes it 🎉 . Update-3: InstanceProvider is also removed. Update-4: All set, the try is green, waiting for dependent changes to go in. Differential Revision: https://phabricator.services.mozilla.com/D49458 UltraBlame original commit: cbec8a55a1bbad484ea0628b527de6f0cc7dc5f7

Simplify Makefile

763e2d4

grovesNL requested a review from kvark October 17, 2019 02:02

Remove sdl2 from CI

b7eb2ad

grovesNL force-pushed the metal-air branch from 0255c17 to 39be040 Compare October 17, 2019 02:51

kvark approved these changes Oct 17, 2019

View reviewed changes

Makefile Outdated Show resolved Hide resolved

metal: build shaders in Makefile instead

5282bee

grovesNL force-pushed the metal-air branch from 39be040 to 5282bee Compare October 17, 2019 23:03

kvark approved these changes Oct 18, 2019

View reviewed changes

bors bot merged commit 5282bee into gfx-rs:master Oct 18, 2019

kvark mentioned this pull request Nov 6, 2019

[meta] Gecko integration tracking gfx-rs/wgpu#374

Closed

14 tasks

kvark mentioned this pull request Mar 13, 2020

Missing instructions for macOS Metal #2472

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build Metal shaders in Makefile instead of build.rs #3047

Build Metal shaders in Makefile instead of build.rs #3047

grovesNL commented Oct 17, 2019

kvark left a comment

bors bot commented Oct 18, 2019

grovesNL commented Oct 18, 2019

bors bot commented Oct 18, 2019

Build Metal shaders in Makefile instead of build.rs #3047

Build Metal shaders in Makefile instead of build.rs #3047

Conversation

grovesNL commented Oct 17, 2019

kvark left a comment

Choose a reason for hiding this comment

bors bot commented Oct 18, 2019

Build failed

grovesNL commented Oct 18, 2019

bors bot commented Oct 18, 2019

Build succeeded