Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGL] Return only RGBA swapchain formats #3699

Merged
merged 1 commit into from
Mar 25, 2021
Merged

[WebGL] Return only RGBA swapchain formats #3699

merged 1 commit into from
Mar 25, 2021

Conversation

Gordon-F
Copy link
Contributor

WebGL doesn't supports BGRA texture formats

PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends: WebGL

kvark
kvark approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thank you!
bors r+

@Gordon-F Gordon-F mentioned this pull request Mar 25, 2021
Closed
@bors
Copy link
Contributor

bors bot commented Mar 25, 2021

Build succeeded:

@bors bors bot merged commit 52f77a6 into gfx-rs:master Mar 25, 2021
@Gordon-F Gordon-F mentioned this pull request Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gordon-F @kvark