Return Rgba8UnormSrgb instead of Bgra8UnormSrgb as default swapchain format for WebGL target #1284
Conversation
…format for WebGL target
| @@ -317,8 +317,14 @@ impl<B: GfxBackend> Adapter<B> { | |||
| return Err(GetSwapChainPreferredFormatError::NotFound); | |||
| } | |||
|
|
|||
| // If no formats were returned, use Bgra8UnormSrgb | |||
| Ok(wgt::TextureFormat::Bgra8UnormSrgb) | |||
| let is_webgl = cfg!(gl) && cfg!(target_arch = "wasm32"); | |||
There was a problem hiding this comment.
I don't think we should be fixing this at the wgpu-core level.
The semantics of supported_formats is:
If None is returned then the surface has no preferred format and the application may use any desired format.
Obviously, this isn't the case for WebGL. So our OpenGL backend has to return a reasonable set of formats here.
There was a problem hiding this comment.
gfx-rs fix - gfx-rs/gfx#3699
Obviously, this isn't the case for WebGL. So our OpenGL backend has to return a reasonable set of formats here
Why we return any formats here if supported_formats is none instead of return None to users?
There was a problem hiding this comment.
Here? Because in wgpu the get_swap_chain_preferred_format has to return one format.
There was a problem hiding this comment.
Thank you for explain! gfx-rs fix should be enough.
WebGL doesn't supports BGRA texture formats