Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support out-of-order module scope declarations in WGSL #1745

Closed
jimblandy opened this issue Feb 23, 2022 · 0 comments · Fixed by #2075
Closed

Support out-of-order module scope declarations in WGSL #1745

jimblandy opened this issue Feb 23, 2022 · 0 comments · Fixed by #2075
Labels
area: front-end Input formats for conversion kind: feature New feature or request lang: WGSL WebGPU shading language
Milestone
WGSL Specificatio...

Comments

@jimblandy
Copy link
Member

As described in §3.8 Declaration and Scope:

A declaration is at module scope if the declaration appears outside the text of any other declaration. Module scope declarations are in scope for the entire program. That is, a declaration at module scope may be referenced by source text that follows or precedes that declaration.

Our front end depends pretty seriously on being able to find definitions when they are referenced.
@jimblandy jimblandy added lang: WGSL WebGPU shading language area: front-end Input formats for conversion labels Feb 23, 2022
@jimblandy jimblandy added this to the WGSL Specification V1 milestone Feb 23, 2022
@kvark kvark added the kind: feature New feature or request label Feb 23, 2022
@SparkyPotato SparkyPotato mentioned this issue Sep 18, 2022
Closed
@SparkyPotato SparkyPotato mentioned this issue Oct 4, 2022
Merged
@teoxoy teoxoy mentioned this issue Nov 15, 2022
Closed
jimblandy added a commit to SparkyPotato/naga that referenced this issue Jan 12, 2023
@SparkyPotato @teoxoy @jimblandy
[wgsl-in] Implement module-level scoping.
1976586 
Fixes gfx-rs#1745: Support out-of-order module scope declarations in WGSL
Fixes gfx-rs#1044: Forbid local variable shadowing in WGSL
Fixes gfx-rs#2076: [wgsl-in] no error for duplicated type definition
Fixes gfx-rs#2071: Global item does not support 'const'
Fixes gfx-rs#2105: [wgsl-in] Type aliases for a vecN<T> doesn't work when constructing vec from a single argument
Fixes gfx-rs#1775: Referencing a function without a return type yields an unknown identifier error.
Fixes gfx-rs#2089: Error span reported on the declaration of a variable instead of its use
Fixes gfx-rs#1996: [wgsl-in] Confusing error: "expected unsigned/signed integer literal, found '1'"

Separate parsing from lowering by generating an AST, which desugars as
much as possible down to something like Naga IR. The AST is then used
to resolve identifiers while lowering to Naga IR.

Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
Co-authored-by: Jim Blandy <jimb@red-bean.com>
jimblandy added a commit that referenced this issue Jan 12, 2023
@SparkyPotato @teoxoy @jimblandy
[wgsl-in] Implement module-level scoping.
6035b07 
Fixes #1745: Support out-of-order module scope declarations in WGSL
Fixes #1044: Forbid local variable shadowing in WGSL
Fixes #2076: [wgsl-in] no error for duplicated type definition
Fixes #2071: Global item does not support 'const'
Fixes #2105: [wgsl-in] Type aliases for a vecN<T> doesn't work when constructing vec from a single argument
Fixes #1775: Referencing a function without a return type yields an unknown identifier error.
Fixes #2089: Error span reported on the declaration of a variable instead of its use
Fixes #1996: [wgsl-in] Confusing error: "expected unsigned/signed integer literal, found '1'"

Separate parsing from lowering by generating an AST, which desugars as
much as possible down to something like Naga IR. The AST is then used
to resolve identifiers while lowering to Naga IR.

Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
Co-authored-by: Jim Blandy <jimb@red-bean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: front-end Input formats for conversion kind: feature New feature or request lang: WGSL WebGPU shading language
Projects
None yet
Milestone
WGSL Specification V1
Development

Successfully merging a pull request may close this issue.

[wgsl-in] Implement module-level scoping SparkyPotato/naga
2 participants
@kvark @jimblandy