Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global item does not support 'const' #2071

Closed
haoyunfeix opened this issue Sep 30, 2022 · 4 comments · Fixed by #2075
Closed

Global item does not support 'const' #2071

haoyunfeix opened this issue Sep 30, 2022 · 4 comments · Fixed by #2075
Labels
area: front-end Input formats for conversion kind: bug Something isn't working lang: WGSL WebGPU shading language

Comments

@haoyunfeix
Copy link

Shader:

      const workGroupSizeX = 256u;
      const workGroupSizeY = 1u;
      const workGroupSizeZ = 1u;

The compiler doesn't like it:
$ naga simple.wgsl

error: expected global item ('struct', 'let', 'var', 'type', ';', 'fn') or the end of the file, found 'const'
  鈹屸攢 simple.wgsl:1:7
  鈹?[0m
1 鈹?[0m       const workGroupSizeX = 256u;
  鈹?[0m       ^^^^^ expected global item ('struct', 'let', 'var', 'type', ';', 'fn') or the end of the file
@SparkyPotato
Copy link
Contributor

SparkyPotato commented Sep 30, 2022

Naga currently uses let for global constants.
It will be fixed in #2065.

@vicary
Copy link

vicary commented Oct 13, 2022

Hey @SparkyPotato, thanks for the reply. Looking forward for the resolution of #2075!

I really hope deno supports TensorFlow.js with WebGPU backend, please do let me know if there is anything I can do to help pushing forward.

@SparkyPotato
Copy link
Contributor

I'm a bit busy right now, but hope to get it done soon.

@vicary
Copy link

vicary commented Oct 13, 2022

@SparkyPotato no worries, take your time!

@JCapucho JCapucho added kind: bug Something isn't working lang: WGSL WebGPU shading language area: front-end Input formats for conversion labels Oct 21, 2022
jimblandy added a commit to SparkyPotato/naga that referenced this issue Jan 12, 2023
Fixes gfx-rs#1745: Support out-of-order module scope declarations in WGSL
Fixes gfx-rs#1044: Forbid local variable shadowing in WGSL
Fixes gfx-rs#2076: [wgsl-in] no error for duplicated type definition
Fixes gfx-rs#2071: Global item does not support 'const'
Fixes gfx-rs#2105: [wgsl-in] Type aliases for a vecN<T> doesn't work when constructing vec from a single argument
Fixes gfx-rs#1775: Referencing a function without a return type yields an unknown identifier error.
Fixes gfx-rs#2089: Error span reported on the declaration of a variable instead of its use
Fixes gfx-rs#1996: [wgsl-in] Confusing error: "expected unsigned/signed integer literal, found '1'"

Separate parsing from lowering by generating an AST, which desugars as
much as possible down to something like Naga IR. The AST is then used
to resolve identifiers while lowering to Naga IR.

Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
Co-authored-by: Jim Blandy <jimb@red-bean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end Input formats for conversion kind: bug Something isn't working lang: WGSL WebGPU shading language
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants