Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spv-out] Emit required decorations on wrapper struct types, too. #1815

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

jimblandy
Copy link
Member

Fixes #1810. Draft PR because it contains no tests. Contains no tests because #1811.

[spv-out] Decorate array and struct type layouts unconditionally.

Remove the decorate_layout variable, which is unconditionally set to true anyway.

@jimblandy
Copy link
Member Author

jimblandy commented Apr 13, 2022

Once #1823 lands, this can be rebased and land.

@jimblandy jimblandy force-pushed the decorate-synthetic-structs branch from 2c9db98 to 3e6ca58 Compare April 13, 2022 02:03
@jimblandy jimblandy force-pushed the decorate-synthetic-structs branch from 3e6ca58 to 01bf472 Compare April 14, 2022 18:49
@jimblandy jimblandy marked this pull request as ready for review April 14, 2022 18:54
@jimblandy jimblandy merged commit bdbf821 into gfx-rs:master Apr 14, 2022
@jimblandy jimblandy deleted the decorate-synthetic-structs branch April 14, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spv-out] wrapping struct types for globals lack required decorations
2 participants