Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit non-struct, non-array types as buffers. #2584

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

jimblandy
Copy link
Member

Fixes #2583.

@jimblandy
Copy link
Member Author

Unfortunately, this is wrong, because the cube example breaks.

@jimblandy
Copy link
Member Author

This is interesting:

[2022-04-07T05:38:28Z ERROR wgpu_hal::vulkan::instance] VALIDATION [UNASSIGNED-CoreValidation-Shader-InconsistentSpirv (0x6bbb14)]
    Validation Error: [ UNASSIGNED-CoreValidation-Shader-InconsistentSpirv ] Object 0: handle = 0x7f0f248b4160, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x6bbb14 | SPIR-V module not valid: Structure id 21 decorated as Block must be explicitly laid out with MatrixStride decorations.
      %_struct_21 = OpTypeStruct %mat4v4float
    
[2022-04-07T05:38:28Z ERROR wgpu_hal::vulkan::instance] objects: (type: DEVICE, hndl: 0x7f0f248b4160, name: ?)
[2022-04-07T05:38:28Z ERROR wgpu_hal::vulkan::instance] VALIDATION [UNASSIGNED-CoreValidation-Shader-InconsistentSpirv (0x6bbb14)]
    Validation Error: [ UNASSIGNED-CoreValidation-Shader-InconsistentSpirv ] Object 0: handle = 0x7f0f248b4160, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x6bbb14 | SPIR-V module not valid: Structure id 21 decorated as Block must be explicitly laid out with MatrixStride decorations.
      %_struct_21 = OpTypeStruct %mat4v4float

@jimblandy
Copy link
Member Author

jimblandy commented Apr 11, 2022

Work is proceeding here in gfx-rs/naga#1815.

@jimblandy
Copy link
Member Author

With gfx-rs/naga#1815 and gfx-rs/naga#1823, this branch works.

@jimblandy jimblandy force-pushed the flexible-buffer-types branch from 41a2f03 to 625af50 Compare April 15, 2022 19:50
@jimblandy jimblandy marked this pull request as ready for review April 15, 2022 19:50
@jimblandy jimblandy requested a review from cwfitzgerald April 15, 2022 19:51
@cwfitzgerald
Copy link
Member

Something went real bad on CI here.

@jimblandy
Copy link
Member Author

The CI failures seem to be gfx-rs/naga#1836 and gfx-rs/naga#1837.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad global type in WGSL causes create_shader_module to panic, not return an error
3 participants