-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit non-struct, non-array types as buffers. #2584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, this is wrong, because the cube example breaks. |
This is interesting:
|
Work is proceeding here in gfx-rs/naga#1815. |
With gfx-rs/naga#1815 and gfx-rs/naga#1823, this branch works. |
jimblandy
force-pushed
the
flexible-buffer-types
branch
from
April 15, 2022 19:50
41a2f03
to
625af50
Compare
Something went real bad on CI here. |
The CI failures seem to be gfx-rs/naga#1836 and gfx-rs/naga#1837. |
kvark
approved these changes
Apr 16, 2022
jimblandy
force-pushed
the
flexible-buffer-types
branch
from
April 18, 2022 16:11
625af50
to
b93f1b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2583.