[glsl] Inject default gl_PointSize = 1.0 in vertex shaders if FORCE_POINT_SIZE option was set
#2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REASY
force-pushed
the
fix/wgpu-3179-set-point-size
branch
3 times, most recently
from
2118afb
to
4df4161
Compare
teoxoy
requested changes
Jan 28, 2023
There was a problem hiding this comment.
I think this needs to be implemented in the same way it is for the spv backend.
Lines 524 to 526 in c7d0215
- rename
allow_point_sizetoforce_point_size - check if we already have (and wrote/will write) the
BuiltIn::PointSize
|
It would also help to include a comment in the code explaining this for future reference with a mention of the section of where it happens in the specification (for glsl ES 3.1 this is in section 7.1.1) |
REASY
force-pushed
the
fix/wgpu-3179-set-point-size
branch
from
4df4161
to
c3e5073
Compare
REASY
commented
Jan 31, 2023
REASY
commented
Jan 31, 2023
REASY
force-pushed
the
fix/wgpu-3179-set-point-size
branch
from
c3e5073
to
f8aff4d
Compare
REASY
commented
Jan 31, 2023
3 tasks
… `FORCE_POINT_SIZE` According to https://registry.khronos.org/OpenGL/specs/es/3.2/GLSL_ES_Specification_3.20.html#built-in-language-variables ``` The variable gl_PointSize is intended for a shader to write the size of the point to be rasterized. It is measured in pixels. If gl_PointSize is not written to, its value is undefined in subsequent pipe stages. ```
- Write warn message if `ClipDistance` and `CullDistance` are used on unsupported version
REASY
force-pushed
the
fix/wgpu-3179-set-point-size
branch
from
f8aff4d
to
cf30dd6
Compare
teoxoy
reviewed
Feb 1, 2023
teoxoy
reviewed
Feb 2, 2023
teoxoy
changed the title
gl_PointSize = 1.0; in case of vertex shader and allow_point_size == truegl_PointSize = 1.0 in vertex shaders if FORCE_POINT_SIZE option was set
REASY
added a commit
to REASY/wgpu
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write
gl_PointSize = 1.0;in case of vertex shader and set writer flagFORCE_POINT_SIZEAccording to https://registry.khronos.org/OpenGL/specs/es/3.2/GLSL_ES_Specification_3.20.html#built-in-language-variables
This is the first part of the changes to address gfx-rs/wgpu#3179