Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce discard only in fragment #2262

Merged
merged 1 commit into from
Feb 27, 2023
Merged

enforce discard only in fragment #2262

merged 1 commit into from
Feb 27, 2023

Conversation

Uriopass
Copy link
Contributor

Fixes #2263

as per wgsl spec "The discard statement must only be used in a fragment shader stage."

@Uriopass Uriopass changed the title forbid discard in compute enforce discard only in fragment Feb 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Merging #2262 (15dc8c9) into master (00be08e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 15dc8c9 differs from pull request most recent head 112a618. Consider uploading reports for the commit 112a618 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    gfx-rs/wgpu#2262   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files          80       80           
  Lines       43241    43242    +1     
=======================================
+ Hits        35481    35484    +3     
+ Misses       7760     7758    -2     
Impacted Files Coverage Δ
src/valid/function.rs 74.09% <100.00%> (+0.04%) ⬆️
src/valid/analyzer.rs 95.22% <0.00%> (+0.12%) ⬆️
src/valid/interface.rs 77.25% <0.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the PR!

@teoxoy teoxoy merged commit a7b52b8 into gfx-rs:master Feb 27, 2023
kvark pushed a commit to kvark/naga that referenced this pull request Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discard is allowed in compute shader stage
3 participants