Differentiate between i32 and u32 in switch #2269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1960.
Updated all instances of
SwitchValue::Integer
to include uints.Renamed
select_cases
toswitch_values
since it did not appear to be used for anything other than switch values.Added a check to validate all cases had similar types. That's just how I interpreted this bit from the spec.
Added a duplicate
SwitchValue
enum to validation since I wasn't sure if adding additional derives tolib
was appropriate or not. This adds a tiny bit of redundancy that I can remove if needed.