Regenerate on sdk-1.3.296.0
#251
Open
+3,651
−1,309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Nov 1, 2024
spirv/autogen_spirv.rs
Outdated
Comment on lines
3104
to
3105
| #[doc = "SPIR-V operand kind: [FPEncoding](https://www.khronos.org/registry/spir-v/specs/unified1/SPIRV.html#_a_id_fp_encoding_a_fp_encoding)"] | ||
| #[repr(u32)] | ||
| #[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)] | ||
| #[cfg_attr(feature = "serialize", derive(serde::Serialize))] | ||
| #[cfg_attr(feature = "deserialize", derive(serde::Deserialize))] | ||
| #[allow(clippy::upper_case_acronyms)] | ||
| pub enum FPEncoding { | ||
| Max = 0x7fffffff, | ||
| } | ||
| impl FPEncoding { | ||
| pub fn from_u32(n: u32) -> Option<Self> { | ||
| Some(match n { | ||
| _ => return None, | ||
| }) | ||
| } | ||
| } | ||
| #[allow(non_upper_case_globals)] | ||
| impl FPEncoding {} | ||
| impl core::str::FromStr for FPEncoding { | ||
| type Err = (); | ||
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| match s { | ||
| _ => Err(()), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a new optional enum operand for OpTypeFloat that's not yet defined to have any values/variants:
https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#FP_Encoding
I made some changes/hacks to autogen to support this variant-less enum, but need more to remove these empty match statements or decide if it should be an opaque enum (newtype struct on u32?) altogether depending on how enum values will be defined in the future.
Specifically `rust-version = "1.58"` in the `autogen` module that I added in #223 is weird, since any developers working on and/or contributing to the repository should easily be able to run the latest stable and take advantage of newer Rust features in `autogen` code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like 1.3.280 is also set for a release (there's a branch but no tag yet) so we might want to hold out merging this until those can be incorporated.