Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Use the new map-async #344

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Use the new map-async #344

merged 1 commit into from
Jun 2, 2020

Conversation

kvark
Copy link
Member

@kvark kvark commented Jun 2, 2020

Depends on gfx-rs/wgpu#675
It changes the API of mapping and removes create_buffer_mapped.
The new functionality is not implemented in Gecko yet, so this breaks the web target, for now.

This was referenced Jun 2, 2020
bors bot added a commit to gfx-rs/wgpu that referenced this pull request Jun 2, 2020
675: New map_async logic r=cwfitzgerald a=kvark

Matches upstream changes in gpuweb/gpuweb#708 and gpuweb/gpuweb#796
TODO:
- wgpu-native PR
- wgpu-rs gfx-rs/wgpu-rs#344

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@kvark kvark marked this pull request as ready for review June 2, 2020 17:57
@kvark
Copy link
Member Author

kvark commented Jun 2, 2020

+210 −419

hell yeah!
bors r+

bors bot added a commit that referenced this pull request Jun 2, 2020
344: Use the new map-async r=kvark a=kvark

Depends on gfx-rs/wgpu#675

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 2, 2020

Build failed:

@kvark
Copy link
Member Author

kvark commented Jun 2, 2020

bors r+

@bors bors bot merged commit 2370602 into gfx-rs:master Jun 2, 2020
@kvark kvark deleted the map-async branch June 2, 2020 18:30
kejor pushed a commit to kejor/wgpu-rs that referenced this pull request Nov 28, 2020
344: Update deps r=kvark a=rukai

We should wait for rust-windowing/winit#1191 to find its way into a winit release before merging this PR.

Co-authored-by: Rukai <rubickent@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant