-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test case provokes Vulkan validation error #2959
Comments
Here's the language from the Vulkan spec (it's included in the validation output, but scrolled off to the side)
|
I'm going to bet this has something to do with the test being expected to panic. It is supposed to reach the |
It seems like Obviously, there should be some sort of |
We must ensure that the staging buffer is not leaked when an error occurs, so allocate it as late as possible, and free it explicitly when those fallible operations we can't move it past go awry. Fixes gfx-rs#2959.
We must ensure that the staging buffer is not leaked when an error occurs, so allocate it as late as possible, and free it explicitly when those fallible operations we can't move it past go awry. Fixes gfx-rs#2959.
We must ensure that the staging buffer is not leaked when an error occurs, so allocate it as late as possible, and free it explicitly when those fallible operations we can't move it past go awry. Fixes gfx-rs#2959.
* Have `prepare_staging_buffer` take a raw hal Device. This helps the borrow checker understand that we can borrow `pending_writes`'s encoder and the raw Device at the same time. * Always free staging buffers. We must ensure that the staging buffer is not leaked when an error occurs, so allocate it as late as possible, and free it explicitly when those fallible operations we can't move it past go awry. Fixes #2959. * Some tests for texture and buffer copies. * Add CHANGELOG.md entry.
I added the following test to
wgpu/tests
, and it provokes the complaints at bottom from the Vulkan validation layer:Here's the validation error:
The text was updated successfully, but these errors were encountered: