Always free staging buffers #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
always-free-staging-buffers
branch
from
8a830d5 to
d6b544f
Compare
This helps the borrow checker understand that we can borrow `pending_writes`'s encoder and the raw Device at the same time.
jimblandy
force-pushed
the
always-free-staging-buffers
branch
from
d6b544f to
0d8ce02
Compare
cwfitzgerald
approved these changes
Aug 14, 2022
jimblandy
force-pushed
the
always-free-staging-buffers
branch
2 times, most recently
from
91dcf10 to
41f287c
Compare
We must ensure that the staging buffer is not leaked when an error occurs, so allocate it as late as possible, and free it explicitly when those fallible operations we can't move it past go awry. Fixes gfx-rs#2959.
jimblandy
force-pushed
the
always-free-staging-buffers
branch
from
41f287c to
9022850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Fixes #2959.
Description
Some platform validation requires that all resources created using a given Device must be freed before the Device itself. Some operations that use
StagingBuffers drop them on the ground if an error occurs.This patch ensures that the staging buffer is not leaked when an error occurs, by allocating it as late as possible, and freeing it explicitly when those fallible operations we can't move its allocation past go awry.
Testing
Tests included in
wgpu/tests.