Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting vsync on Intel integrated has validation error #350

Closed
m4b opened this issue Oct 17, 2019 · 6 comments
Closed

Setting vsync on Intel integrated has validation error #350

m4b opened this issue Oct 17, 2019 · 6 comments
Labels
good first issue Good for newcomers type: bug Something isn't working

Comments

@m4b
Copy link
Contributor

m4b commented Oct 17, 2019

when i switch to NoVsync i get this validation warning (it does appear however to not vsync anymore):

VALIDATION [VUID-VkSwapchainCreateInfoKHR-presentMode-01281 (0)] : vkCreateSwapchainKHR() called with a non-supported presentMode (i.e. VK_PRESENT_MODE_IMMEDIATE_KHR). The Vulkan spec states: presentMode must be one of the VkPresentModeKHR values returned by vkGetPhysicalDeviceSurfacePresentModesKHR for the surface (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-VkSwapchainCreateInfoKHR-presentMode-01281)
object info: (type: DEVICE, hndl: 94235621371968)

This is on archlinux with intel integrated card
@m4b
Copy link
Contributor Author

m4b commented Oct 17, 2019

And this is on wgpu 0.3.3 crates io version

@kvark kvark added type: bug Something isn't working good first issue Good for newcomers labels Oct 17, 2019
@kvark
Copy link
Member

kvark commented Oct 17, 2019

Basically, we need to consider the available presentation modes when choosing one. In the worst case, we keep Vsync ON.

@m4b
Copy link
Contributor Author

m4b commented Oct 17, 2019

So what is strange to me is how could it not be vsyncing now if my card is reporting it cannot be put in a NON vsync mode ?

@kvark
Copy link
Member

kvark commented Oct 17, 2019

Found the relevant TODO:

wgpu/wgpu-native/src/swap_chain.rs

Line 98 in 78fbbba

//TODO: check for supported

@kvark
Copy link
Member

kvark commented Oct 17, 2019

The supported present are obtained here:

wgpu/wgpu-native/src/device.rs

Line 1987 in 78fbbba

let (caps, formats, _present_modes) = {

You can add a info! log to print these out and see.

@Veykril Veykril mentioned this issue Dec 28, 2019
Merged
bors bot added a commit that referenced this issue Dec 30, 2019
@bors @Veykril
Merge #424
369fd77 
424: swapchain creation: check if selected present mode is supported r=kvark a=Veykril

Implements a simple check as talked about in #350 to fallback to `FIFO` should the selected present mode not be available on the system.

Co-authored-by: Veykril <lukastw97@gmail.com>
bors bot added a commit that referenced this issue Dec 30, 2019
@bors @Korijn
@fintelia @Veykril
Merge #416 #420 #424
890bbcf 
416: Makefile package command and travis github releases r=kvark a=Korijn

Closes #414

Approach mostly mimicked from [gfx-portability](https://github.com/gfx-rs/portability) as recommended to me by @kvark. I needed a number of commits to iron out some kinks for the Windows builds, so I would recommend using squash merge when accepting this PR.

Note that the Windows rust=nightly build fails, but it's also broken on master, so it's unrelated to the changes in this PR.

/cc @almarklein

# Questions

- [x] Would it make sense to also regenerate the `ffi/wgpu.h` and `wgpu-remote.h` header files and include them in the zip archive?

# Todo for maintainers

- [x] Configure encrypted `api_key`
As in [gfx-portability](https://github.com/gfx-rs/portability/blob/master/.travis.yml#L61) you will need to create an API key and commit it to the `.travis.yml` file. I've checked "allow edits from maintainers" so you should be able to commit to this branch directly. You may want to reference the [Travis instructions](https://docs.travis-ci.com/user/deployment/releases/#authenticating-with-an-oauth-token) as well.

- [ ] Tag revisions
Previous versions (`v0.1` - `v0.4`) have not been tagged on the master branch, you will want to do so retroactively. Also, when releasing in the future, make sure to tag the commit before pushing. Alternatively, you can schedule a travis build manually after applying the tag retroactively.

420: Make Origin3d::{x,y,z} all have type u32 r=kvark a=fintelia

Fixes #419 

424: swapchain creation: check if selected present mode is supported r=kvark a=Veykril

Implements a simple check as talked about in #350 to fallback to `FIFO` should the selected present mode not be available on the system.

Co-authored-by: Korijn van Golen <k.vangolen@clinicalgraphics.com>
Co-authored-by: Korijn van Golen <korijn@gmail.com>
Co-authored-by: Jonathan Behrens <fintelia@gmail.com>
Co-authored-by: Veykril <lukastw97@gmail.com>
@paulkernfeld
Copy link
Contributor

I think this was fixed by #424.

@kvark kvark closed this as completed May 4, 2020
kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
@bors @cwfitzgerald
[rs] Merge gfx-rs#350
5f567e2 
350: Implement Extensions Interface r=kvark a=cwfitzgerald

This implements gfx-rs#703 in wgpu-rs. Notable changes include the removal of the anisotropic field from the examples, in favor of the now mandatory `..Default::default()` syntax.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
@John-Nagle John-Nagle mentioned this issue Apr 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @paulkernfeld @m4b