Use Bitshift Style for All Bitflag Consts #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zicklag
force-pushed
the
bitshift-style-bitflags
branch
from
26680b6
to
60f792d
Compare
cwfitzgerald
approved these changes
Jul 28, 2021
wgpu-types/src/lib.rs
Outdated
| /// Enables clear to zero for buffers & images. | ||
| /// | ||
| /// Supported platforms: | ||
| /// - All | ||
| /// | ||
| /// This is a native only feature. | ||
| const CLEAR_COMMANDS = 0x0000_0400_0000_0000; | ||
| const CLEAR_COMMANDS = 1 << 42; |
There was a problem hiding this comment.
I was just copying what the existing flags were, I wasn't sure if there was a reason for the jump or not. If it's native only are these values not tied to the WebGPU spec?
There was a problem hiding this comment.
Yeah they aren't. I don't know why we would jump here. Likely just due to how difficult maintaining the old way was :)
There was a problem hiding this comment.
Ok, pushed an update to fix.
zicklag
force-pushed
the
bitshift-style-bitflags
branch
from
60f792d
to
d0acfe6
Compare
This makes existing bitflags easier to read and makes it eaiser to add new flags later.
zicklag
force-pushed
the
bitshift-style-bitflags
branch
from
d0acfe6
to
fd460fa
Compare
|
Thanks! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
None exactly, but somewhat related to #1686 as I was going to put some of this change into that PR, but am splitting it out for ease of review.
Description
This is purely code-style related, but it makes it easier to read bitflag constants and much eaiser to add bitflags in the future.
Testing
Tested on Ubuntu 20.04