Implement view_formats for SurfaceConfiguration

[jinleili]

Checklist

• Run cargo clippy.
• Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
• Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Follow up to #3237

Testing
Tested locally except deno part

[crowlKats]

Deno part looks good to me.

If you want, i can test the deno change, but am unsure how viewformats are used. Though, given its a simple & straight-forward change, testing it doesnt seem too necessary

[teoxoy]

We should validate the viewFormats in validate_surface_configuration
according to https://gpuweb.github.io/gpuweb/#dom-gpucanvascontext-configure.

Otherwise, looks good!

[jinleili]

Looking at the #3399 implementation, I'm not sure if the Vulkan backend needs to be handled separately here as well.

[teoxoy]

Thanks for updating the validation but there is one more rule:

Validate texture format required features of each element of configuration.viewFormats with device.[[device]].

Ideally, we'd share some validation for the TextureDescriptor and the configure fn... but not a blocker.

Looking at the #3399 implementation, I'm not sure if the Vulkan backend needs to be handled separately here as well.

I don't think we need to do anything extra for Vulkan here. @cwfitzgerald can maybe confirm?

[cwfitzgerald]

Yeah, I think we need mutable format on the swapchain via https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkSwapchainCreateFlagBitsKHR.html and VK_KHR_swapchain_mutable_format. This is fine on desktop, but has zero support on android.

[jinleili]

Yeah, I think we need mutable format on the swapchain via https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkSwapchainCreateFlagBitsKHR.html and VK_KHR_swapchain_mutable_format. This is fine on desktop, but has zero support on android.

The addition of the corresponding extension KhrImageFormatListFn was in #3412

[teoxoy]

VK_KHR_image_format_list can be optional but it seems to be required if we require VK_KHR_swapchain_mutable_format?
Maybe we should land #3412 first and make it required in this PR if that's the case.

Or can we still set VK_SWAPCHAIN_CREATE_MUTABLE_FORMAT_BIT_KHR and not give a format list?

[jinleili]

I checked the VK_KHR_swapchain_mutable_format extension on Android 13 devices, and sure enough, it's not supported on Android devices.

VK_KHR_image_format_list can be optional but it seems to be required if we require VK_KHR_swapchain_mutable_format?

Yes, after re-reading the documentation, they should all be required. Since VK_KHR_imageless_framebuffer also requires VK_KHR_image_format_list, the permission of this extension has to be determined separately.

[teoxoy]

2 remaining things and we should be good to go.
Thanks for addressing all the comments!

[cwfitzgerald]

Adopting this PR so we can get it in this release