Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move require_downlevel_flags(VIEW_FORMATS)? to create_texture() #3420

Merged
merged 1 commit into from
Jan 25, 2023
Merged

move require_downlevel_flags(VIEW_FORMATS)? to create_texture() #3420

merged 1 commit into from
Jan 25, 2023

Conversation

jinleili
Copy link
Contributor

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.

Connections
Follow up to #3409

Description
move require_downlevel_flags(VIEW_FORMATS)? from create_texture_view() to create_texture()

Testing
Tested locally via cargo nextest run --package wgpu --test wgpu-tests -- shader_view_format

teoxoy
teoxoy approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teoxoy teoxoy merged commit 969af43 into gfx-rs:master Jan 25, 2023
@jinleili jinleili deleted the downlevel_flag branch January 26, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinleili @teoxoy