[naga] Use const ctx instead of global ctx for const resolution #6935
+52
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
sagudev
force-pushed
the
local-const-type
branch
from
aa746b2 to
11e5e8b
Compare
sagudev
changed the title
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
sagudev
force-pushed
the
local-const-type
branch
from
4789239 to
8650618
Compare
|
I have a feeling we need to recheck evals and all arena invariants. Distinction between global const ctx and local const ctx is very blurry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fix #6720, depends on #6945
Description
Naga currently assumes constants are global and it passes global ctx to const needing functions. Instead we should pass const ctx (expr ctx) that can represents either local or global consts.
Testing
There will be CTS run in servo and some new tests.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.