[naga] Explicitly use global const ctx in offset #6945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
sagudev
commented
Jan 18, 2025
Comment on lines
+375
to
376
| #[allow(dead_code)] | ||
| fn as_const(&mut self) -> ExpressionContext<'source, '_, '_> { |
There was a problem hiding this comment.
It might make sense to remove this and add it back later.
There was a problem hiding this comment.
I agree; the PR would become a one line change then.
I think it would be fine to fold it into #6935. Or would you still like to land this separately?
There was a problem hiding this comment.
I think it would make sense to land it as it stands now.
There was a problem hiding this comment.
Or maybe not given how clippy/rustdoc hates me, but I would still like to land this separately. Reverted to initial version.
sagudev
changed the title
teoxoy
approved these changes
Jan 20, 2025
sagudev
force-pushed
the
try-const
branch
2 times, most recently
from
afb5706 to
d0ce4e1
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Preparation for #6935
Description
Most of wgsl-in assumes constants are only global. In order to fix this in #6935 this PR makes TetureSampler offset explicitly use global const ctx and removes
as_conston expr ctx.Testing
This is tested by existing tests
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.