Add Stencil8 and Rgb9e5uFloat texture formats #955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
kvark
requested changes
Oct 5, 2020
| @@ -383,6 +384,7 @@ pub(crate) fn map_texture_format( | |||
| H::D32SfloatS8Uint | |||
| } | |||
| } | |||
| Tf::Stencil8 => H::S8Uint, | |||
There was a problem hiding this comment.
We need this conditional on what the adapter supports. See how it's done for Depth24Plus. Here, we'd need even more choices: it will be S8Uint, or D24UnormS8Uint, or D32SfloatS8Uint.
There was a problem hiding this comment.
Sure thing, will make this change. I'm probably going to be predisposed until this weekend, sorry for the delay.
|
@lachlansneff can we revive and land this, please? |
|
Can we revive and land this, please? |
|
Sure thing, will do this evening if I have time. Sorry about the delay. |
|
ping! |
|
Bump from triage :) |
|
I'm going to close this as it will need to be completely recreated for wgpu-hal. #1703 covers Rgb9e5UFloat, but Stencil8 still isn't implemented. |
bors bot
added a commit
that referenced
this pull request
Jul 22, 2021
1703: Add Rgb9e5Ufloat Format r=kvark a=cwfitzgerald **Connections** Addresses part of #967, a wgpu-hal followup to #955. **Description** This adds only `Rgb9e5Ufloat`. I removed the explicit numbering from the texture format so we don't have to constantly re-number things. The default numbering is identical to what we were doing. **Testing** All backends unconditionally support it, so little testing is needed. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
matrix
Description
This adds Stencil8 and Rgb9e5uFloat texture formats.
Testing
No testing required, afaik.