Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make : improve cpuinfo handling on x86 hosts #1238

Merged
merged 4 commits into from
Sep 5, 2023
Merged

make : improve cpuinfo handling on x86 hosts #1238

merged 4 commits into from
Sep 5, 2023

Conversation

przemoc
Copy link
Contributor

@przemoc przemoc commented Sep 1, 2023

No description provided.

@przemoc
make : simplify and correct x86 ISA extensions detection on the host
aabf893 
It got broken in commit c5f9acf for Haiku and Mac OS (Intel),
which report CPU features in upper case.

Now we're finding the names in case-insensitive manner and as words.
SSE3 detection has been corrected for Linux, which uses PNI for that
(Prescott New Instructions).
@przemoc
make : use dmesg.boot in FreeBSD/DragonFlyBSD to detect x86 ISA exten…
28e525e 
…sions on the host
@przemoc
make : enable x86 ISA extensions on the host both in CFLAGS and CXXFLAGS
b3c9e42
@przemoc przemoc mentioned this pull request Sep 1, 2023
Closed
@przemoc
Copy link
Contributor Author

przemoc commented Sep 1, 2023

Not having access to any macOS machine is such a pain, but I don't plan buying anyone soon.
If there is some kind soul reading this message accidentally and willing to give some macOS (Intel or ARM, ideally both) shell account/access free of charge to random stranger (myself), please let me know via mail. I promise to use it only for open-source related activities and not abuse it.

@bobqianic
Copy link
Collaborator

Not having access to any macOS machine is such a pain, but I don't plan buying anyone soon.
If there is some kind soul reading this message accidentally and willing to give some macOS (Intel or ARM, ideally both) shell account/access free of charge to random stranger (myself), please let me know via mail. I promise to use it only for open-source related activities and not abuse it.

Using the college's electricity and internet to set up a M1 Mac Mini server is feasible, but this will have to wait until October when I return to college.

@przemoc przemoc mentioned this pull request Sep 3, 2023
Merged
@ggerganov ggerganov merged commit ba3c333 into ggerganov:master Sep 5, 2023
35 checks passed
@przemoc przemoc deleted the improve-cpuinfo-handling-in-make branch September 6, 2023 20:38
bdonkey added a commit to bdonkey/whisper.cpp that referenced this pull request Sep 13, 2023
@bdonkey
Merge branch 'master' into ssdev
f82bf11 
* master: (96 commits)
  whisper : fix bench regression + fix performance when using CPU BLAS (ggerganov#1275)
  whisper : faster beam_search sampling via reduced KV cache copies (ggerganov#1243)
  java : fixed signing of java artifact using gradle (ggerganov#1267)
  ci : try to fix gradle action (ggerganov#1265)
  gitignore : update
  sync : ggml (HBM + Metal + style) (ggerganov#1264)
  ci : upgrade gradle to 2.4.2 (ggerganov#1263)
  sync : ggml (CUDA faster rope)
  cmake : noramlize case (ggerganov#1129)
  build : do not use _GNU_SOURCE gratuitously (ggerganov#1129)
  examples : fix build + compile warnings (close ggerganov#1256)
  models : add quantum models to download-ggml-model.sh (ggerganov#1235)
  whisper.android : bump gradle plugin and dependencies + a lint pass (ggerganov#1255)
  sign jar for Maven Central repo
  whisper.android : address ARM's big.LITTLE arch by checking cpu info (ggerganov#1254)
  make : fix detection of AVX2 on macOS (ggerganov#1250)
  ggml : posixify pagesize (ggerganov#1251)
  configured publishing.repositories
  ggml : sync latest llama.cpp (view_src + alloc improvements) (ggerganov#1247)
  make : improve cpuinfo handling on x86 hosts (ggerganov#1238)
  ...
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@przemoc
make : improve cpuinfo handling on x86 hosts (ggerganov#1238)
30191cd 
* make : simplify and correct x86 ISA extensions detection on the host

It got broken in commit c5f9acf for Haiku and Mac OS (Intel),
which report CPU features in upper case.

Now we're finding the names in case-insensitive manner and as words.
SSE3 detection has been corrected for Linux, which uses PNI for that
(Prescott New Instructions).

* make : use dmesg.boot in FreeBSD/DragonFlyBSD to detect x86 ISA extensions on the host

* make : enable x86 ISA extensions on the host both in CFLAGS and CXXFLAGS

* make : correct AVX x86 ISA extension detection on macOS (Intel) host

It got broken in commit c5f9acf.  macOS calls it AVX1.0.
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@przemoc
make : improve cpuinfo handling on x86 hosts (ggerganov#1238)
ed58e16 
* make : simplify and correct x86 ISA extensions detection on the host

It got broken in commit c5f9acf for Haiku and Mac OS (Intel),
which report CPU features in upper case.

Now we're finding the names in case-insensitive manner and as words.
SSE3 detection has been corrected for Linux, which uses PNI for that
(Prescott New Instructions).

* make : use dmesg.boot in FreeBSD/DragonFlyBSD to detect x86 ISA extensions on the host

* make : enable x86 ISA extensions on the host both in CFLAGS and CXXFLAGS

* make : correct AVX x86 ISA extension detection on macOS (Intel) host

It got broken in commit c5f9acf.  macOS calls it AVX1.0.
vonstring pushed a commit to vonstring/whisper.cpp that referenced this pull request Nov 7, 2023
@przemoc @vonstring
make : improve cpuinfo handling on x86 hosts (ggerganov#1238)
e49ba65 
* make : simplify and correct x86 ISA extensions detection on the host

It got broken in commit c5f9acf for Haiku and Mac OS (Intel),
which report CPU features in upper case.

Now we're finding the names in case-insensitive manner and as words.
SSE3 detection has been corrected for Linux, which uses PNI for that
(Prescott New Instructions).

* make : use dmesg.boot in FreeBSD/DragonFlyBSD to detect x86 ISA extensions on the host

* make : enable x86 ISA extensions on the host both in CFLAGS and CXXFLAGS

* make : correct AVX x86 ISA extension detection on macOS (Intel) host

It got broken in commit c5f9acf.  macOS calls it AVX1.0.
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
@przemoc
make : improve cpuinfo handling on x86 hosts (ggerganov#1238)
584becb 
* make : simplify and correct x86 ISA extensions detection on the host

It got broken in commit c5f9acf for Haiku and Mac OS (Intel),
which report CPU features in upper case.

Now we're finding the names in case-insensitive manner and as words.
SSE3 detection has been corrected for Linux, which uses PNI for that
(Prescott New Instructions).

* make : use dmesg.boot in FreeBSD/DragonFlyBSD to detect x86 ISA extensions on the host

* make : enable x86 ISA extensions on the host both in CFLAGS and CXXFLAGS

* make : correct AVX x86 ISA extension detection on macOS (Intel) host

It got broken in commit c5f9acf.  macOS calls it AVX1.0.
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
@przemoc @iThalay
make : improve cpuinfo handling on x86 hosts (ggerganov#1238)
7a3d7a1 
* make : simplify and correct x86 ISA extensions detection on the host

It got broken in commit c5f9acf for Haiku and Mac OS (Intel),
which report CPU features in upper case.

Now we're finding the names in case-insensitive manner and as words.
SSE3 detection has been corrected for Linux, which uses PNI for that
(Prescott New Instructions).

* make : use dmesg.boot in FreeBSD/DragonFlyBSD to detect x86 ISA extensions on the host

* make : enable x86 ISA extensions on the host both in CFLAGS and CXXFLAGS

* make : correct AVX x86 ISA extension detection on macOS (Intel) host

It got broken in commit c5f9acf.  macOS calls it AVX1.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@przemoc @bobqianic @ggerganov