Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of AVX2 on macOS #1250

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

didzis
Copy link
Contributor

@didzis didzis commented Sep 5, 2023

AVX2 is not detected by Makefile on macOS, this PR fixes that.

@przemoc
Copy link
Contributor

przemoc commented Sep 6, 2023

@didzis, thanks for catching that.

Can you show what your macOS is (version, CPU, uname -a) and dump what those sysctls show in isolation (sysctl machdep.cpu.features, sysctl machdep.cpu.leaf7_features). It's helpful for those not having macOS.

@didzis
Copy link
Contributor Author

didzis commented Sep 6, 2023

$ uname -a
Darwin whatever.local 21.6.0 Darwin Kernel Version 21.6.0: Mon Apr 24 21:10:53 PDT 2023; root:xnu-8020.240.18.701.5~1/RELEASE_X86_64 x86_64
$ sysctl machdep.cpu.features machdep.cpu.leaf7_features 
machdep.cpu.features: FPU VME DE PSE TSC MSR PAE MCE CX8 APIC SEP MTRR PGE MCA CMOV PAT PSE36 CLFSH DS ACPI MMX FXSR SSE SSE2 SS HTT TM PBE SSE3 PCLMULQDQ DTES64 MON DSCPL VMX EST TM2 SSSE3 FMA CX16 TPR PDCM SSE4.1 SSE4.2 x2APIC MOVBE POPCNT AES PCID XSAVE OSXSAVE SEGLIM64 TSCTMR AVX1.0 RDRAND F16C
machdep.cpu.leaf7_features: RDWRFSGS TSC_THREAD_OFFSET SGX BMI1 AVX2 SMEP BMI2 ERMS INVPCID FPU_CSDS MPX RDSEED ADX SMAP CLFSOPT IPT SGXLC MDCLEAR TSXFA IBRS STIBP L1DF ACAPMSR SSBD

@ggerganov ggerganov merged commit 64cb45f into ggerganov:master Sep 6, 2023
34 checks passed
bdonkey added a commit to bdonkey/whisper.cpp that referenced this pull request Sep 13, 2023
* master: (96 commits)
  whisper : fix bench regression + fix performance when using CPU BLAS (ggerganov#1275)
  whisper : faster beam_search sampling via reduced KV cache copies (ggerganov#1243)
  java : fixed signing of java artifact using gradle (ggerganov#1267)
  ci : try to fix gradle action (ggerganov#1265)
  gitignore : update
  sync : ggml (HBM + Metal + style) (ggerganov#1264)
  ci : upgrade gradle to 2.4.2 (ggerganov#1263)
  sync : ggml (CUDA faster rope)
  cmake : noramlize case (ggerganov#1129)
  build : do not use _GNU_SOURCE gratuitously (ggerganov#1129)
  examples : fix build + compile warnings (close ggerganov#1256)
  models : add quantum models to download-ggml-model.sh (ggerganov#1235)
  whisper.android : bump gradle plugin and dependencies + a lint pass (ggerganov#1255)
  sign jar for Maven Central repo
  whisper.android : address ARM's big.LITTLE arch by checking cpu info (ggerganov#1254)
  make : fix detection of AVX2 on macOS (ggerganov#1250)
  ggml : posixify pagesize (ggerganov#1251)
  configured publishing.repositories
  ggml : sync latest llama.cpp (view_src + alloc improvements) (ggerganov#1247)
  make : improve cpuinfo handling on x86 hosts (ggerganov#1238)
  ...
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
vonstring pushed a commit to vonstring/whisper.cpp that referenced this pull request Nov 7, 2023
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
@didzis didzis deleted the macos-detect-avx2 branch February 3, 2024 23:27
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants