Remove #if arch(arm) check in Swift Package Manager #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
approved these changes
Dec 4, 2023
|
Should be done in https://github.com/ggerganov/llama.cpp/blob/master/Package.swift too. |
bobqianic
approved these changes
Dec 5, 2023
|
Opened a PR for llama.cpp |
landtanin
pushed a commit
to landtanin/whisper.cpp
that referenced
this pull request
Dec 16, 2023
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Dec 20, 2023
* origin/master: bench.py : add different large models (ggerganov#1655) wchess : update README.md release : v1.5.2 wchess : update readme wchess : whisper assisted chess (ggerganov#1595) sync : ggml (Metal fixes, new ops, tests) (ggerganov#1633) cmake : target windows 8 or above for prefetchVirtualMemory in llama-talk (ggerganov#1617) cmake : Fix bug in httplib.h for mingw (ggerganov#1615) metal : fix `ggml_metal_log` vargs (ggerganov#1606) whisper.objc : disable timestamps for real-time transcription whisper : more debug messages + fix fallback logic metal : fix soft_max kernel src1 argument (ggerganov#1602) sync : ggml (new ops, new backend, etc) (ggerganov#1602) server : pass max-len argument to the server (ggerganov#1574) ios : Remove `#if arch(arm)` check for using Metal (ggerganov#1561) ggml : Fix 32-bit compiler warning (ggerganov#1575) ggml : re-enable blas for src0 != F32 (ggerganov#1583)
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume the
#if arch(arm) || arch(arm64)is meant to prevent older Intel macs from using Metal, however checking this here doesn't really work. This check is executed on the machine compiling the package, and it is very likely that the machine compiling the package is not the machine that a compiled app will run on.Current Behaviour:
This is especially problematic for me as Xcode Cloud builds are currently done on Intel machines, so Metal will not be used in built apps.
This PR enables Metal no matter what the compiling architecture is. In the case of running a universal app on an Intel mac, there is still the issue that Metal will be enabled when it probably shouldn't be (maybe a runtime check should be added?), however I think it is much more likely that you will want Metal enabled when using SPM (all iOS devices are Apple Silicon, and more and more macs are Apple Silicon)