-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync : ggml (new ops, new backend, etc) #1602
Conversation
@slaren Did I mess-up the sync, or is this some issue with Windows: https://github.com/ggerganov/whisper.cpp/actions/runs/7129122907/job/19412511626 |
This seems to be caused by the code to register backends automatically on startup. The macros used for this depend heavily on the compiler and can be finicky, but it should work on MSVC. It does work on ggml and llama.cpp, so I am not sure what is different here. |
there's a bug somewhere in this commit for metal. running the same thing works fine with previous commit sorry to not have more info, the metal bits go way over my head and make me so so grateful for these awesome libraries :) |
@zshannon Should be fixed on By the way, can you explain how you run the Edit: nevermind - something was wrong with my Xcode project. I re-cloned the repo from scratch and it works now |
Hi @ggerganov , on the latest commit I naively tried the solution from #1607 but to no avail. Crashes occur when I run it on an iPhone 13 with the To make it work on the same phone, I either
Notes: I use a simple wav file with only a few seconds of spoken words. My app code is based on P.S. this can never be said enough, thanks for this amazing project 🙌 |
This is fixed in v1.5.2 released 👍 |
* sync : ggml (new ops, new backend, etc) * whisper : remove obsolete broadcasting code * ggml : remove backend self-registers + fix ggml_concat + n_task logic * metal : fix assert * metal : print resource path * whisper : fix bug if metal init fails
This commit seems to break large-v3 CoreML for me. |
@AuroraWright Can you confirm that on latest Does anyone else experience issues on latest |
@ggerganov yeah with latest master too, it seems mc = 0 fixes it |
* origin/master: bench.py : add different large models (ggerganov#1655) wchess : update README.md release : v1.5.2 wchess : update readme wchess : whisper assisted chess (ggerganov#1595) sync : ggml (Metal fixes, new ops, tests) (ggerganov#1633) cmake : target windows 8 or above for prefetchVirtualMemory in llama-talk (ggerganov#1617) cmake : Fix bug in httplib.h for mingw (ggerganov#1615) metal : fix `ggml_metal_log` vargs (ggerganov#1606) whisper.objc : disable timestamps for real-time transcription whisper : more debug messages + fix fallback logic metal : fix soft_max kernel src1 argument (ggerganov#1602) sync : ggml (new ops, new backend, etc) (ggerganov#1602) server : pass max-len argument to the server (ggerganov#1574) ios : Remove `#if arch(arm)` check for using Metal (ggerganov#1561) ggml : Fix 32-bit compiler warning (ggerganov#1575) ggml : re-enable blas for src0 != F32 (ggerganov#1583)
* sync : ggml (new ops, new backend, etc) * whisper : remove obsolete broadcasting code * ggml : remove backend self-registers + fix ggml_concat + n_task logic * metal : fix assert * metal : print resource path * whisper : fix bug if metal init fails
No description provided.