linenoise.cpp refactoring #11301
Merged
linenoise.cpp refactoring #11301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
force-pushed
the
linenoise.cpp2
branch
2 times, most recently
from
b98e210 to
1d187c0
Compare
More RAII mainly Signed-off-by: Eric Curtin <ecurtin@redhat.com>
ericcurtin
force-pushed
the
linenoise.cpp2
branch
from
1d187c0 to
cf32856
Compare
|
This is good for review @ggerganov @slaren |
ggerganov
approved these changes
Jan 21, 2025
anagri
pushed a commit
to BodhiSearch/llama.cpp
that referenced
this pull request
Jan 26, 2025
More RAII mainly Signed-off-by: Eric Curtin <ecurtin@redhat.com>
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
More RAII mainly Signed-off-by: Eric Curtin <ecurtin@redhat.com>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
More RAII mainly Signed-off-by: Eric Curtin <ecurtin@redhat.com>
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
More RAII mainly Signed-off-by: Eric Curtin <ecurtin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More RAII mainly