Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo for c.ShouldBindBodyWithPlain comment #4066

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

kingcanfish
Copy link
Contributor

@kingcanfish kingcanfish commented Oct 6, 2024

  • fix typo for c.ShouldBindBodyWithPlain comment

ShouldBindBodyWithJSON is a shortcut for c.ShouldBindBodyWith(obj, binding.JSON). -> ShouldBindBodyWithPlain is a shortcut for c.ShouldBindBodyWith(obj, binding.Plain).

  • by the way, fix some test functions in context_test.go for passing golang-lint

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (3dc1cd6) to head (4b97320).
Report is 76 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4066      +/-   ##
==========================================
- Coverage   99.21%   99.09%   -0.12%     
==========================================
  Files          42       44       +2     
  Lines        3182     2887     -295     
==========================================
- Hits         3157     2861     -296     
+ Misses         17       15       -2     
- Partials        8       11       +3     
Flag Coverage Δ
?
-tags "sonic avx" 99.09% <ø> (?)
-tags go_json 99.09% <ø> (?)
-tags nomsgpack 99.08% <ø> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 99.09% <ø> (-0.12%) ⬇️
go-1.22 99.09% <ø> (?)
macos-latest 99.09% <ø> (-0.12%) ⬇️
ubuntu-latest 99.09% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy added this to the v1.11 milestone Oct 25, 2024
@appleboy appleboy merged commit 647311a into gin-gonic:master Oct 25, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants