-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tree): Keep panic infos consistent when wildcard type build faild #4077
Conversation
#4066 This PR fixed the ci-lint faild code |
build failed |
waiting for #4081 |
please update the branch to the latest version. |
c50ffd1
to
3af8f5f
Compare
thank you for your review. I have updated to the latest version, but the golangci-lint still fails. in my machine, golangci-lint (v1.60.2) is success, the same version as on github(v1.58.1) failed to run, |
… failed and update ci-lint version
3af8f5f
to
26f5476
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4077 +/- ##
==========================================
- Coverage 99.21% 98.96% -0.25%
==========================================
Files 42 44 +2
Lines 3182 3478 +296
==========================================
+ Hits 3157 3442 +285
- Misses 17 25 +8
- Partials 8 11 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
update the golangci-lint to v1.62.0 :) |
@kingcanfish Thanks. |
fix(tree): Keep panic infos consistent when wildcard type build faild
When I run the demo1
it got the panic:
panic: no / before catch-all in path '/abc/x*z'
but when i run the demo2
it got the panic:
panic: runtime error: index out of range [-1]
Although the end result is the same(panic), the different panic informations may cause some confusion.
So, add the
i < 0
condition to keep the panic infos same