Use sparse communicator in distributed::Matrix #1549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelKoch
force-pushed
the
sparse-comm
branch
2 times, most recently
from
bf1654d
to
89bdbbd
Compare
This was referenced Mar 25, 2024
Merged
|
This probably needs to be rebased ? |
MarcelKoch
force-pushed
the
distributed-matrix-with-sparse-comm
branch
from
f63b12a
to
8efe6c2
Compare
pratikvn
reviewed
Mar 31, 2024
Comment on lines
+526
to
+530
| [[deprecated( | ||
| "The pre-C++17 interface of the distributed::Matrix is " | ||
| "deprecated, please update your C++ standard to 17. ")]] mpi::request | ||
| communicate(const local_vector_type* local_b) const; | ||
| #endif |
There was a problem hiding this comment.
I think the communicate function should be the responsibility of this class rather than the sparse_communicator class.
MarcelKoch
force-pushed
the
distributed-matrix-with-sparse-comm
branch
from
8efe6c2
to
1ee0afd
Compare
MarcelKoch
force-pushed
the
distributed-matrix-with-sparse-comm
branch
2 times, most recently
from
938f37c
to
98382b9
Compare
MarcelKoch
force-pushed
the
distributed-matrix-with-sparse-comm
branch
from
98382b9
to
d6bca1a
Compare
MarcelKoch
force-pushed
the
distributed-matrix-with-sparse-comm
branch
from
d6bca1a
to
2a9c216
Compare
MarcelKoch
force-pushed
the
sparse-comm
branch
2 times, most recently
from
63ba23d
to
1df6ad3
Compare
MarcelKoch
force-pushed
the
distributed-matrix-with-sparse-comm
branch
from
2a9c216
to
08e0391
Compare
MarcelKoch
force-pushed
the
distributed-matrix-with-sparse-comm
branch
2 times, most recently
from
17f51dc
to
0f2abc1
Compare
MarcelKoch
force-pushed
the
distributed-matrix-with-sparse-comm
branch
from
0f2abc1
to
17f51dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #1546
This PR enables using the sparse-communicator in the
distributed::Matrix. It is only available if the C++17 standard is used, otherwise the old implementation will be used. But I will also deprecate the old implementation, so we won't maintain two separate code paths.PR Stack: