Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Index map device kernels #1579

Merged
merged 4 commits into from
May 14, 2024
Merged

Adds Index map device kernels #1579

merged 4 commits into from
May 14, 2024

Conversation

MarcelKoch
Copy link
Member

@MarcelKoch MarcelKoch commented Mar 25, 2024

@MarcelKoch MarcelKoch self-assigned this Mar 25, 2024
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. mod:cuda This is related to the CUDA module. mod:openmp This is related to the OpenMP module. mod:hip This is related to the HIP module. mod:dpcpp This is related to the DPC++ module. labels Mar 25, 2024
@MarcelKoch MarcelKoch mentioned this pull request Mar 25, 2024
6 tasks
@MarcelKoch MarcelKoch marked this pull request as draft March 25, 2024 10:35
@pratikvn pratikvn self-requested a review March 25, 2024 10:54
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch 4 times, most recently from c700b1c to 989967d Compare April 4, 2024 11:00
@MarcelKoch MarcelKoch added this to the Ginkgo 1.8.0 milestone Apr 5, 2024
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch 2 times, most recently from 989967d to cc997ff Compare April 25, 2024 07:18
@MarcelKoch MarcelKoch marked this pull request as ready for review April 30, 2024 13:49
@MarcelKoch MarcelKoch force-pushed the index-map branch 2 times, most recently from f7fa971 to 95ab009 Compare May 7, 2024 12:51
Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few minor things, which are mostly nits.

test/distributed/index_map_kernels.cpp Outdated Show resolved Hide resolved
@MarcelKoch MarcelKoch force-pushed the index-map-device-kernels branch 5 times, most recently from 585009b to 80e2802 Compare May 8, 2024 18:53
@MarcelKoch MarcelKoch force-pushed the index-map branch 2 times, most recently from 4e0efb4 to 92a2e8d Compare May 9, 2024 08:56
@MarcelKoch MarcelKoch added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels May 10, 2024
@MarcelKoch MarcelKoch force-pushed the index-map branch 2 times, most recently from 656bb7c to 4dc3658 Compare May 13, 2024 09:43
Base automatically changed from index-map to develop May 13, 2024 20:48
@MarcelKoch MarcelKoch merged commit d35f2e1 into develop May 14, 2024
10 of 15 checks passed
@MarcelKoch MarcelKoch deleted the index-map-device-kernels branch May 14, 2024 13:13
Copy link

sonarcloud bot commented May 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. mod:cuda This is related to the CUDA module. mod:dpcpp This is related to the DPC++ module. mod:hip This is related to the HIP module. mod:openmp This is related to the OpenMP module. reg:build This is related to the build system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants