Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building Python 3.11 wheels #697

Merged
merged 5 commits into from
May 29, 2024

Conversation

raphaelreinauer
Copy link
Contributor

@raphaelreinauer raphaelreinauer commented May 29, 2024

Description:

• Updated CIBW_BUILD to include cp311-* for Python 3.11.
• Updated comments in the wheels workflow
• Add Python311 to azure-pipelines.yml
• Updates setup.py to include Python 3.11

This PR fixes multiple Issues:
#696
#674
#671

Note: This PR depends on
giotto-ai/pyflagser#82
giotto-ai/giotto-ph#76

@CLAassistant
Copy link

CLAassistant commented May 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@matteocao matteocao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably remove python 3.7 if it causes CI problems, as it is not supported anymore

@matteocao
Copy link
Contributor

@raphaelreinauer given that the CI was using a very old approach, I merged the PR that was supposed to fix it.

Please fix the conflicts (and remove python 3.7). I will then force-merge this

@raphaelreinauer
Copy link
Contributor Author

@raphaelreinauer given that the CI was using a very old approach, I merged the PR that was supposed to fix it.

Please fix the conflicts (and remove python 3.7). I will then force-merge this

I've merged in the current master and removed python 3.7.

@matteocao matteocao merged commit ce420b5 into giotto-ai:master May 29, 2024
1 check passed
@raphaelreinauer raphaelreinauer mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants