Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building Python 3.11 wheels #82

Merged
merged 3 commits into from
May 29, 2024

Conversation

raphaelreinauer
Copy link
Contributor

Description:

• Updated CIBW_BUILD to include cp311-* for Python 3.11.
• Updated comments in wheels workflow

CIBW_BUILD: "cp37-* cp38-* cp39-* cp310-*"
# Skip 32 bit architectures, musllinux, and i686, and macOS x86_64 wheels for CP3.8 -- CP3.10
CIBW_SKIP: "*-win32 *-musllinux_x86_64 *_i686 cp38-macosx_x86_64 cp39-macosx_x86_64 cp310-macosx_x86_64"
CIBW_BUILD: "cp37-* cp38-* cp39-* cp310-* cp311-*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raphaelreinauer feel free to remove python 3.7 as well. It is anyway not supported anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this will make the CI pass and we can merge your PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do. Should I add Python 3.12 as well?

@matteocao
Copy link
Contributor

@raphaelreinauer can you pelase also update the ci.yml file like so:

Screenshot 2024-05-29 at 22 35 27

Same for your PR on giotto-ph

@matteocao matteocao merged commit e9a406a into giotto-ai:master May 29, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants