Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorties pour ft #281

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

sorties pour ft #281

wants to merge 2 commits into from

Conversation

laurinehu
Copy link
Contributor

**Carte Notion : **

Pourquoi ?

Indiquer le problème que nous sommes en train de résoudre et les objectifs métiers ou techniques qui sont visés par ces changements.

Checks

  • J'ai lancé le modèle ou seed sur un dump local (si pertinent)
  • J'ai ajouté des tests à mon code Python, ou des assertions DBT sur le modèle SQL
  • J'ai documenté ce modèle voire certains de ses champs (usage métier, tableau de bord, etc)

@laurinehu laurinehu marked this pull request as draft April 17, 2024 16:06
@laurinehu laurinehu force-pushed the laurinehu/croisement_fluxiae_ft branch 3 times, most recently from 3eaf697 to 6c8a33e Compare April 19, 2024 09:49
@laurinehu laurinehu force-pushed the laurinehu/croisement_fluxiae_ft branch 2 times, most recently from f87f0a3 to 4ee7043 Compare May 7, 2024 12:27
@@ -6,6 +6,6 @@
) }}

select distinct
{{ pilo_star(source('fluxIAE', 'fluxIAE_Salarie'), except=["hash_numéro_pass_iae"]) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

garder l'except

@laurinehu laurinehu force-pushed the laurinehu/croisement_fluxiae_ft branch from 659d588 to fba4078 Compare May 13, 2024 07:51
@laurinehu laurinehu marked this pull request as ready for review May 13, 2024 08:08
@laurinehu laurinehu force-pushed the laurinehu/croisement_fluxiae_ft branch 2 times, most recently from 615fc73 to c463c62 Compare May 13, 2024 09:07
@laurinehu laurinehu force-pushed the laurinehu/croisement_fluxiae_ft branch from c463c62 to bdf5086 Compare May 13, 2024 09:18
@@ -0,0 +1,10 @@
select
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

candidats pk ? Candidats parce que mdrrrrr

Copy link
Contributor

@YannickPassa YannickPassa May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quand je quitterai le gip j'espere que mon futur employeur ira voir mes commentaires de PR avant de m'embaucher

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭😭😭 que de rigolades entre les pk et les fdp

candidat_emploi.id as id_candidat_emplois,
candidat_emploi.hash_nir as hash_nir
from {{ source('fluxIAE', 'fluxIAE_Salarie') }} as salarie_asp
left join {{ source('emplois', 'pass_agréments') }} as pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention dans la table pass agréments il y a des doublons, peut etre que ça vaudrait le coup de les retirer

-- - du nord
-- - un pass IAE a été attribué entre le 1 janvier 2021 et le 30 juin 2023.
where
salarie_asp.salarie_code_dpt = '059'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flute je viens de voir ça...
La tu as pris les salariés habitant dans le 59 mais peut etre que tu as des salariés dans un département limitrophe et qui travaillent dans le 59. On est surs qu'on les veut pas ceux là ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsie... zut je vais voir avec aurélie merci j'y avais pas pensé

Copy link
Contributor

@YannickPassa YannickPassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tres bien mais verifie cette histoire de doublons dans la table pass
et merci pour la table candidats pk

@laurinehu
Copy link
Contributor Author

en attente de vérification des NIR pour remplacer la jointure sur le hash par une jointure via le NIR

@laurinehu laurinehu marked this pull request as draft May 23, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants