Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch pour corriger le dbt daily qui plante #337

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Patch pour corriger le dbt daily qui plante #337

merged 1 commit into from
Jul 23, 2024

Conversation

laurinehu
Copy link
Contributor

@laurinehu laurinehu commented Jul 22, 2024 •
edited
Loading

**Carte Notion : **

  • Suppression des scripts ft (sont corrigés dans une autre PR)
  • Modification du format de date qui fait planter candidats_derniere_embauche

Checks

  • J'ai lancé le modèle ou seed sur un dump local (si pertinent)
  • J'ai ajouté des tests à mon code Python, ou des assertions DBT sur le modèle SQL
  • J'ai documenté ce modèle voire certains de ses champs (usage métier, tableau de bord, etc)

@laurinehu laurinehu requested a review from YannickPassa July 22, 2024 09:54
@laurinehu laurinehu self-assigned this Jul 22, 2024
@laurinehu laurinehu requested a review from rsebille July 22, 2024 09:54
YannickPassa
YannickPassa reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@YannickPassa YannickPassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ou as tu mis les scripts ft candidats et candidatures ?

@laurinehu
Copy link
Contributor Author

@YannickPassa dans cette PR #281

@YannickPassa YannickPassa self-requested a review July 23, 2024 12:39
@laurinehu laurinehu added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 8473980 Jul 23, 2024
5 checks passed
@laurinehu laurinehu deleted the laurinehu/ft_correct branch July 23, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannickPassa YannickPassa YannickPassa approved these changes

@rsebille rsebille Awaiting requested review from rsebille

Assignees

@laurinehu laurinehu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurinehu @YannickPassa