Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bug #12

wants to merge 1 commit into from

Conversation

changh95
Copy link

Hi @gisbi-kim ,

Before I begin, I'd like to thank you for making a great repo! The code here is very intuitive.

I found a bug in the function 'saveOptimizedGraphPose'. Although this bug is minor, any kind of derivative works may encounter big issues due to this, so I'm suggesting a fix. I myself also found this bug as I was integrating KISS-ICP and scan-context, based on this repo.

Many thanks!
감사합니다 기섭님 :)

- The last component of an SE(3) matrix was written as 0.1, when it should have been 1.0.
- Although this problem is minor, and lets PyICP-SLAM work fine, however it makes problems for all derivative works based on this repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant