Add height to the group #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguellsegarra
approved these changes
Dec 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
# [2.26.0](v2.25.0...v2.26.0) (2024-12-13) ### Features * **group:** add height ([#160](#160)) ([a5a85e7](a5a85e7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
heightproperty to theGroupclass insrc/Group.tsand includes corresponding unit tests to ensure the property is set correctly. The main changes include adding getter and setter methods for theheightproperty and updating the constructor to handle the new property.Changes to
Groupclass:_heightproperty with getter and setter methods to theGroupclass insrc/Group.ts.Groupclass constructor to parse and set theheightproperty from the providedpropsobject.Unit tests:
src/spec/Group.spec.tsto verify that theheightproperty can be set and retrieved correctly.