installer: reflect the fact that FSMonitor is no longer experimental #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FSMonitor feature is no longer experimental, and hasn't been so for quite a while. It also does not make sense to enable it on all repositories, as the performance of using FSMonitor with small repositories is potentially worse than without using the FSMonitor. So let's disable the option, telling the user why. This addresses git-for-windows/git#4570, at long last. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Seeing a disabled option that the user never enabled may be quite confusing. So maybe just disabling it may be desirable only in scenarios where users had enabled it? So let's in fact not even show the FSMonitor option unless the user is upgrading and had the option checked in the previous run. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
rimrul
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is also recommended only for larger repositories/worktrees. So let's not show the option at all anymore unless it had been enabled in the previous installation and the user is upgrading/reinstalling. And even then, disable it.
This addresses git-for-windows/git#4570, at long last.
This is how the Experimental Options page looks now if the user had the FSMonitor feature enabled previously:
And this is how it looks like in fresh installs or when upgrading from an installation where FSMonitor was disabled: