Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GfW Installer still labels FSMonitor as experimental #4570

Closed
jeffhostetler opened this issue Aug 23, 2023 · 1 comment · Fixed by git-for-windows/build-extra#570
Closed

GfW Installer still labels FSMonitor as experimental #4570

jeffhostetler opened this issue Aug 23, 2023 · 1 comment · Fixed by git-for-windows/build-extra#570
Labels
enhancement installer
Milestone
v2.46.0

Comments

@jeffhostetler
Copy link

The installer still lists FSMonitor as being experimental. We should change that. However, since FSMonitor is only really needed very large repos, we may not want to default it on or set the flag globally. We might just want to advise them to set it locally on their monorepos, for example.
dscho added a commit to dscho/build-extra that referenced this issue Jul 17, 2024
@dscho
installer: disable the "experimental" FSMonitor setting
0f3e11b 
The FSMonitor feature is no longer experimental, and hasn't been so for
quite a while. It also does not make sense to enable it on all
repositories, as the performance of using FSMonitor with small
repositories is potentially worse than without using the FSMonitor.

So let's disable the option, telling the user why.

This addresses git-for-windows/git#4570, at
long last.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho mentioned this issue Jul 17, 2024
Merged
@dscho dscho linked a pull request Jul 17, 2024 that will close this issue
installer: reflect the fact that FSMonitor is no longer experimental git-for-windows/build-extra#570
Merged
@dscho dscho added this to the Next release milestone Jul 17, 2024
@dscho
Copy link
Member

dscho commented Jul 18, 2024 •
edited by gitforwindowshelper bot
Loading

/add relnote feature The FSMonitor feature is no longer experimental, and therefore no longer offered as installer option. Users are encouraged to enable this on a per-repository basis, via the config setting core.fsmonitor=true (scalar clone does this automatically).

The workflow run was started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement installer
Projects
None yet
Milestone
v2.46.0
Development

Successfully merging a pull request may close this issue.

installer: reflect the fact that FSMonitor is no longer experimental dscho/build-extra
3 participants
@dscho @rimrul @jeffhostetler